[#2065] Confirm and decline instructor signups #2143

pbanaszkiewicz · 2022-03-15T07:35:45Z

This fixes #2065.

"Confirm" button
"Confirm" button triggers automated email
"Decline" button
"Confirm" and "Decline" buttons manage user instructor tasks for that event
Disable editing instructor's entry once it has been confirmed or declined (to be implemented as part of Instructor Selection: resign from upcoming teaching opportunity #2069)
Tests

…ruitments

…idation

This is WIP. For now mypy isn't used in pre-commit or in the CI pipelines.

This will prevent circular-import in future once typings are added (next commit).

CSS and message content slightly changed.

pbanaszkiewicz changed the title ~~Feature/2065 confirm decline signups~~ [#2065] Confirm and decline instructor signups Mar 27, 2022

pbanaszkiewicz added 5 commits March 27, 2022 20:23

[carpentries#2065] Add faker commands to generate fake instructor rec…

ac8a92a

…ruitments

[carpentries#2065] Fix admin assignee for fake data

6b47e18

[carpentries#2065] Display assignee on recruitment list

e896a6b

[carpentries#2065] Improve recruitment list display

06af7e4

[carpentries#2065] Basic confirm/decline signup view without much val…

273f6fc

…idation

pbanaszkiewicz force-pushed the feature/2065-confirm-decline-signups branch from 30513ba to 8f09335 Compare April 3, 2022 10:49

pbanaszkiewicz added 3 commits April 3, 2022 12:51

[carpentries#2065] Update signup state change view

4b3f15f

[carpentries#2065] Add mypy + stub libraries

275eea9

This is WIP. For now mypy isn't used in pre-commit or in the CI pipelines.

[carpentries#2065] Display signup state visually

256b9f8

pbanaszkiewicz force-pushed the feature/2065-confirm-decline-signups branch from 8f09335 to 256b9f8 Compare April 3, 2022 10:51

pbanaszkiewicz added 8 commits April 3, 2022 13:01

[carpentries#2065] Improve URL redirects and links for better UX

105fd76

[carpentries#2065] Update ACL for Recruitment State change view

17ebd65

[carpentries#2065] Add tests

b4e3d91

[carpentries#2065] Manage instructor tasks during Signup approval

3e6ae5d

[carpentries#2065] Move autoemails bulk email around

c15b3ba

This will prevent circular-import in future once typings are added (next commit).

[carpentries#2065] Autoemails: improve typing

eac894e

[carpentries#2065] Improve email (un)schedule messages

a339165

CSS and message content slightly changed.

[carpentries#2065] Add/remove automated email for instructor signup

4d5f17b

pbanaszkiewicz marked this pull request as ready for review April 3, 2022 15:24

pbanaszkiewicz requested a review from fmichonneau April 3, 2022 15:25

pbanaszkiewicz self-assigned this Apr 3, 2022

pbanaszkiewicz added type: new feature component: database (DB) python Pull requests that update Python code component: email automation labels Apr 3, 2022

pbanaszkiewicz added this to the v3.5 milestone Apr 3, 2022

pbanaszkiewicz merged commit 4f66dbb into carpentries:develop Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#2065] Confirm and decline instructor signups #2143

[#2065] Confirm and decline instructor signups #2143

pbanaszkiewicz commented Mar 15, 2022 •

edited

Loading

[#2065] Confirm and decline instructor signups #2143

[#2065] Confirm and decline instructor signups #2143

Conversation

pbanaszkiewicz commented Mar 15, 2022 • edited Loading

pbanaszkiewicz commented Mar 15, 2022 •

edited

Loading