Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor Selection: confirm or decline signups #2065

Closed
pbanaszkiewicz opened this issue Sep 24, 2021 · 3 comments · Fixed by #2143
Closed

Instructor Selection: confirm or decline signups #2065

pbanaszkiewicz opened this issue Sep 24, 2021 · 3 comments · Fixed by #2143

Comments

@pbanaszkiewicz
Copy link
Contributor

pbanaszkiewicz commented Sep 24, 2021

As an admin user, I want to be able to confirm or decline signups from either event signup listing, or from all events signup listing.

Acceptance criteria:

  1. Clicking "Confirm" adds a task for instructor (or supporting instructor) for this user and this event - this should trigger email automation mechanism (EDIT: "confirm instructor for the workshop", but not "introduce Host with Instructors")
  2. Clicking "Confirm" changes signup status to "confirmed"
  3. Clicking "Decline" sends an email "Thank you for your interest… we have placed other Instructors… please continue to …." (EDIT: moved to Instructor Selection: close recruitment process #2066)
  4. Clicking "Decline" changes signup status to "declined"
  5. Once confirmed or declined, signup entry may not be edited by the user.

UPDATE 2021-10-18: updated according to @maneesha comment down below.

@maneesha
Copy link
Contributor

maneesha commented Oct 1, 2021

About item 1 - Clicking "confirm" should immediately send an email letting the Instructor know they are confirmed, but not the email introducing Host and Instructors. That email should go out after registration is closed.

About item 3 - Clicking "Decline" should not immediately send out an email. That email should go out after registration is closed (see #2066).

About item 5 - not sure if this means may not be edited by the instructor user or by the admin user. We do not want the instructor user to edit this, but do want the admin user to be able to edit this.

@pbanaszkiewicz
Copy link
Contributor Author

@maneesha both this and #2066 were updated!

I have a question about logic when admin user first accepts instructor ("confirm instructor for the workshop" is sent out), but then decides to decline the instructor (no email is sent). Do you think it should stay this way?

@maneesha
Copy link
Contributor

If we confirm an instructor and then have to decline, that would happen through personal communication and would not be part of this system.

@pbanaszkiewicz pbanaszkiewicz self-assigned this Mar 14, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Mar 15, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Mar 15, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Mar 15, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
This is WIP. For now mypy isn't used in pre-commit or in the CI
pipelines.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
This is WIP. For now mypy isn't used in pre-commit or in the CI
pipelines.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
This will prevent circular-import in future once typings are added
(next commit).
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 3, 2022
CSS and message content slightly changed.
pbanaszkiewicz added a commit that referenced this issue Apr 5, 2022
…line-signups

[#2065] Confirm and decline instructor signups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants