Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that the re-run triggers changed in Snakemake 7.8.0 #40

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

jdblischak
Copy link
Contributor

Instructions

Thanks for contributing! ❤️

If this contribution is for instructor training, please email the link to this contribution to
[email protected] so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at [email protected].

You may delete these instructions from your comment.

- The Carpentries

Related to my review at carpentries-lab/reviews#17

@tbooth
Copy link
Collaborator

tbooth commented Sep 26, 2023

This is part of the general issue of how to deal with Snakemake changes. Having dug down into the Snakemake code, I can say that the newer rerun triggers do not (at least a few months ago did not) actually work as advertised, and as Ezra noted in #36 there is some feeling in the community that detecting this set of changes is over-complex and problematic.

So I'll accept this PR for now but really I need to see if the course should be running with Snakemake 7 and if so what else in the course needs to change - probably not much structurally but a bunch of little details and sample outputs.

@tbooth tbooth merged commit 004f647 into carpentries-incubator:gh-pages Sep 26, 2023
@jdblischak jdblischak deleted the 7.8-re-run branch September 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants