Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index and setup page not linked properly #12

Open
dpshelio opened this issue Aug 28, 2018 · 2 comments
Open

index and setup page not linked properly #12

dpshelio opened this issue Aug 28, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@dpshelio
Copy link
Contributor

At least when online on gh-pages the index and setup pages for English are getting a 404 because jekyll is not building them as: /index/ or /setup/. This could be solved by adding permlinks to these.

@dpshelio dpshelio added the help wanted Extra attention is needed label Oct 6, 2019
@dpshelio
Copy link
Contributor Author

Probably we need to change https://github.com/carpentries-i18n/carp-theme/blob/e7710037f29f126b5810425ccdd747f81a4a0806/_includes/navbar.html#L37 to point only to include.pathLocale and on the index.md pages for source and translated languages to have the following options:

  • Source:
root: .  
permalink: index.html
  • translation:
root: es
permalink: es/index.html

as index is the only page that doesn't follow the pattern /:path/index.html

Similarly for other pages:

  • CoC:

  • source

    root: .
    permlink: /conduct/
    
  • translation

    root: es
    permlink: es/conduct/
    

    (though we need to check how we want to refer to this page: coc,conduct,code_of_conduct,...
    The "official" theme uses: CODE_OF_CONDUCT.html. However, the problem then is that the translations will become: es/CODE_OF_CONDUCT/index.html and that's harder to wire)

  • Setup:

  • source

    root: .
    permlink: /setup/
    
  • translation

    root: es
    permlink: es/setup/
    
  • License:

  • source

permalink: /LICENSE/
root: .
  • translation
root: es
permalink: /LICENSE/
  • episodes/AIO:
  • source
permalink: /aio/
permalink: /aio/index.html
  • translation
permalink: es/aio/
permalink: es/aio/index.html
  • extras/reference:

     root: .
     permlink: /reference/
    

    and as above for the translations...

  • extras/about:

     permlink: /about/
    
  • extras/design, extras/discuss, extras/exercises, extras/guide are like the above.

  • extras/figures => has the link to figures/index and that one works without any change!

@TomKellyGenetics
Copy link

(though we need to check how we want to refer to this page: coc,conduct,code_of_conduct,...
The "official" theme uses: CODE_OF_CONDUCT.html. However, the problem then is that the translations will become: es/CODE_OF_CONDUCT/index.html and that's harder to wire)

Switching between languages doesn't work if the files are names differently. If they're all called CODE_OF_CONDUCT and have a permalink: */conduct/ field it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants