Remade of: Add assets for Japanese #9
Conversation
ja for Japanese language locale jp for Japan country locale https://www.localeplanet.com/icu/ja-JP/index.html
This reverts commit ffb86f4. I don't understand why removing the base_path that sets relative paths
|
@TomKellyGenetics notice I've reverted your "correct home index" as I'm not sure how this was changing the output. I believe I've fixed the Home Index with #8 which I'll merge and test it on some lessons that has carpentries-i18n/carpentry-theme#12 included on ther lessons. |
|
Thanks, the Japanese assets seem to be in order. I've tried using the updated theme. The "Home" button linking to "index.html" seems to work in Japanese (or Spanish) but not in English. The Set Up or LICENSE pages won't display either. Perhaps I'm missing some links required in the English repo. swcarpentry/python-novice-gapminder@gh-pages...carpentries-i18n:gh-pages I'll need more time to look into this but I think changes to the theme won't be needed to fix it. |
|
I think it's safe to close issue #2 if you're okay to merge this. I've managed to generate lessons with the correct links as addressed here: |
This is the same as #7 opened by @TomKellyGenetics but only with the changes that should be include.
For some reason, old commits that were already in this repository appeared in the PR as with a different commit number and therefore a whole list of commits was brought bringing also a new set of branches.
Thanks @TomKellyGenetics!!