Allow URL customisation and specifying subset of CRUD roles. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2024
Closed
carltongibson
force-pushed
the
custom-roles
branch
from
4b3afc4 to
0951236
Compare
Route only some roles:
BookmarkView.get_urls(roles={Role.LIST, Role.DETAIL})
Plus, specify url_base, and path_converter for URL routing.
Co-authored-by: Kasun Herath <[email protected]>
carltongibson
force-pushed
the
custom-roles
branch
from
532c170 to
ea58e0b
Compare
| url_base = view_cls.url_base | ||
| url_kwarg = view_cls.lookup_url_kwarg or view_cls.lookup_field | ||
| path_converter = view_cls.path_converter | ||
| match self: |
|
Nicely done. It'll be nice to delete some class overrides and possibly templates that were mostly serving to override the action values/links. 🎉 |
|
@jefftriplett @joshuadavidthomas still has a few open issues about the actions list… #39, #40, #41 — so it might not clear up the template, just yet. Main points are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route only some roles:
BookmarkView.get_urls(roles={Role.LIST, Role.DETAIL})
Plus, specify url_base, and path_converter for URL routing.
Fixes #11
Fixes #32
cc. @kasun @joshuadavidthomas @jefftriplett