Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lookup field configurable #5

Closed
joshuadavidthomas opened this issue Nov 14, 2023 · 2 comments
Closed

Make lookup field configurable #5

joshuadavidthomas opened this issue Nov 14, 2023 · 2 comments

Comments

@joshuadavidthomas
Copy link
Member

joshuadavidthomas commented Nov 14, 2023 •
edited
Loading

carltongibson#11

neapolitan/src/neapolitan/views.py

Lines 461 to 465 in 1347545

# TODO: make the lookup field configurable. Determined by
# lookup_field and lookup_url_kwarg. ???: how to handle the type of
# the converter? (int, slug, etc.)
# It's just a string that gets passed to path(). SO an extra view
# field with the name of a registered converter.

carltongibson#28 (though I don't particularly like mount_url as a variable tbh)
@carltongibson
Copy link

Yes, still pondering this one too.

@carltongibson
Copy link

Right, pondered. See carltongibson#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carltongibson @joshuadavidthomas