Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs 114: Character sprite scaling fix #143

Merged

Conversation

Whyshchuck
Copy link
Collaborator

@Whyshchuck Whyshchuck commented Dec 29, 2023

In order to solve problems listed in
#141
room's method update_character_scale function name had been changed as it's private no more.
unfortunately in next PR:
#142
one of references in popochiu_region restored the outdated name.

Following PR covers fix of:

  • above mentioned bug and
  • avoids transfer of characters' position to the next room (via character's position_stored variable)

@stickgrinder
Copy link
Collaborator

LGTM, merging

@stickgrinder stickgrinder merged commit 3216c1b into carenalgas:2.0 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants