Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs 114: character sprite scaling regions update #141

Merged
merged 9 commits into from
Dec 28, 2023
Merged

Refs 114: character sprite scaling regions update #141

merged 9 commits into from
Dec 28, 2023

Conversation

Whyshchuck
Copy link
Collaborator

@Whyshchuck Whyshchuck commented Dec 24, 2023 •
edited
Loading

This is update to my earlier PR.
It resolves 2 bugs observed during further tests:

  • characters with bigger collision polygons had tendency to scale exceeding maximum and minimum scale set for top and bottom of region;
  • in some cases scale didn't applied to characters before room's fade in. They either shrinked just after load or didnt scale until any character moved.
    Both issues should now be fixed
  • scaling works only for main room. Regions in all other rooms have scaling=False and scale_top and _bottom ==1

mapedorr
mapedorr requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@mapedorr mapedorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ask for a change on those lines of code that are too long in popochiu_room.gd.

addons/popochiu/engine/objects/room/popochiu_room.gd Outdated Show resolved Hide resolved
addons/popochiu/engine/objects/region/popochiu_region.gd Show resolved Hide resolved
mapedorr
mapedorr approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@mapedorr mapedorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!!!

@mapedorr mapedorr merged commit 38df124 into carenalgas:2.0 Dec 28, 2023
@Whyshchuck Whyshchuck mentioned this pull request Dec 29, 2023
Merged
mapedorr pushed a commit that referenced this pull request Feb 18, 2024
@Whyshchuck @mapedorr
Refs 114: character sprite scaling regions update (#141)
e5be351 
* scaling regions added

* lines length reduced according to mepedorr comment

* fix to update characters' position just after  room load

* sprite scale change strictly limited to region's top and bottom scale

* check and update character scale on room load fix

* line length reduced according to mapedorr comment

* update to avoid caching default regions parameters preventing scaling rooms other than main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapedorr mapedorr mapedorr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Whyshchuck @mapedorr