#87 Add warning when loop metadata is missing for AudioStreamWAV #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapedorr
reviewed
Nov 9, 2023
| AudioStreamWAV.LOOP_FORWARD if value\ | ||
| else AudioStreamWAV.LOOP_DISABLED | ||
| if (audio as AudioStreamWAV).get_loop_end() == 0 && value: | ||
| push_warning("res://addons/popochiu/engine/audio_manager/audio_cue.gd:97 " + resource_name + " does not have the correct metadata for loop, please check AudioStreamWAV documentation") |
There was a problem hiding this comment.
I suggest using this way of displaying the warning so that it is understood as something triggered by the plugin and avoid long code lines:
PopochiuUtils.print_warning(
"[b]%s[/b]" % resource_name +\
" does not have the correct metadata to loop, please check" +\
" AudioStreamWAV documentation"
)There was a problem hiding this comment.
that's great, I will change it
mapedorr
added a commit
that referenced
this pull request
Nov 10, 2023
* Fix "Start with it" for inventory items. fix: Devs can select items to start with in the Main tab. fix: Setting an inventory item as active with `add_as_active` makes the cursor take the appearance of the item. fea: Added `is_pixel_art_game` property to ProjectSettings. upd: When selecting Pixel in Game type (setup popup) the default texture filter is set to TEXTURE_FILTER_NEAREST for props, characters and inventory items. * #87 Add warning when loop metadata is missing for AudioStreamWAV (#104) * Add warning for AudioStreamWAV in audio_cue.gd * Fix comments on the PR * NPC's follows the player (#105) * initial commit to let npc's follow the player * Fix comments on the PR * Add `v_frames` property to PopochiuProp. fea: Add settings option for pixel perfect games. fea: The cursor sprite doesn't leave the viewport when the mouse pointer leaves the game window. fea: When the game is pixel perfect, the cursor moves in whole pixels (thanks to @Whyshchuck ) * Updated max size for plugin popups --------- Co-authored-by: Juan Ferrari <[email protected]>
mapedorr
added a commit
that referenced
this pull request
Nov 10, 2023
* Fix "Start with it" for inventory items. fix: Devs can select items to start with in the Main tab. fix: Setting an inventory item as active with `add_as_active` makes the cursor take the appearance of the item. fea: Added `is_pixel_art_game` property to ProjectSettings. upd: When selecting Pixel in Game type (setup popup) the default texture filter is set to TEXTURE_FILTER_NEAREST for props, characters and inventory items. * #87 Add warning when loop metadata is missing for AudioStreamWAV (#104) * Add warning for AudioStreamWAV in audio_cue.gd * Fix comments on the PR * NPC's follows the player (#105) * initial commit to let npc's follow the player * Fix comments on the PR * Add `v_frames` property to PopochiuProp. fea: Add settings option for pixel perfect games. fea: The cursor sprite doesn't leave the viewport when the mouse pointer leaves the game window. fea: When the game is pixel perfect, the cursor moves in whole pixels (thanks to @Whyshchuck ) * Updated max size for plugin popups --------- Co-authored-by: Juan Ferrari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #87
What
This PR adds a warning in the Godot console to help developers notice that the WAV file added does not have the correct metadata to loop
Why
Is not a bug from Popochiu per se, according to godotengine/godot#40359 if the metadata is not present a WAV file won't loop.