Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone input component #1860

Merged
merged 20 commits into from
Dec 19, 2024
Merged

Add phone input component #1860

merged 20 commits into from
Dec 19, 2024

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Nov 30, 2024

Refer to https://linear.app/cardstack/issue/CS-7589/create-phoneinput-component

What is changing

  • add phone input component in boxel-ui
    Screenshot 2024-12-18 at 8 11 46 PM

Examples

Searchable country selector
Screenshot 2024-12-02 at 22 34 21
Valid state
Screenshot 2024-12-02 at 22 35 00
Invalid state
Screenshot 2024-12-02 at 22 34 48

Notes

  • country list and phone number libraries are lived inside in boxel-ui as discussed in boxel team meeting
  • we used awesome-phonenumber instead of libphonenumber-js. Though libphonenumber-js its more popular but the awesome-phonenumber suggest improvement in bundle sizes etc

@tintinthong tintinthong marked this pull request as draft November 30, 2024 17:38
Copy link

github-actions bot commented Nov 30, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   20m 42s ⏱️ +6s
712 tests ±0  710 ✔️ ±0  2 💤 ±0  0 ±0 
717 runs  ±0  715 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 1fce6bc. ± Comparison against base commit 7131849.

♻️ This comment has been updated with latest results.

@tintinthong tintinthong force-pushed the add-phone-input-component branch from 9ce543a to a77fef4 Compare December 2, 2024 03:17
@richardhjtan richardhjtan marked this pull request as ready for review December 18, 2024 13:13
@richardhjtan richardhjtan requested review from a team December 18, 2024 13:13
@lucaslyl lucaslyl self-requested a review December 19, 2024 09:22
@tintinthong
Copy link
Contributor Author

Looks good thanks

@richardhjtan richardhjtan merged commit b0bbab5 into main Dec 19, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants