Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create phone number field #1862

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Create phone number field #1862

merged 8 commits into from
Dec 19, 2024

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Dec 2, 2024 •
edited by richardhjtan
Loading

Refer to https://linear.app/cardstack/issue/CS-7412/create-phonefield

What is changing

  • add new phone number field

Screenshots

Empty state
Screenshot 2024-12-18 at 9 01 55 PM
Screenshot 2024-12-18 at 8 23 51 PM

Filled state
Screenshot 2024-12-18 at 9 01 48 PM
Screenshot 2024-12-18 at 8 23 38 PM

CRM contact
Screenshot 2024-12-18 at 9 01 26 PM
Screenshot 2024-12-18 at 9 01 13 PM

@tintinthong tintinthong changed the title Add-phone-number-field Add phone number field Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Host Test Results

    1 files  ±0      1 suites  ±0   20m 17s ⏱️ -12s
712 tests ±0  710 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
717 runs  ±0  715 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 906b2b0. ± Comparison against base commit 55a1df4.

♻️ This comment has been updated with latest results.

@tintinthong tintinthong changed the title Add phone number field Create phone number field Dec 2, 2024
@tintinthong tintinthong force-pushed the add-phone-number-field branch from ec874f9 to e430bdc Compare December 2, 2024 06:11
@tintinthong tintinthong marked this pull request as draft December 2, 2024 08:30
@richardhjtan richardhjtan marked this pull request as ready for review December 18, 2024 13:14
@richardhjtan richardhjtan requested a review from a team December 18, 2024 13:14
tintinthong
tintinthong commented Dec 19, 2024
View reviewed changes
Copy link
Contributor Author

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@richardhjtan richardhjtan merged commit 21a8e27 into add-phone-input-component Dec 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaslyl lucaslyl lucaslyl approved these changes

Assignees

@tintinthong tintinthong

@richardhjtan richardhjtan

Labels
card
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tintinthong @lucaslyl @richardhjtan