fix(tearsheet): address portalTarget type #6400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makafsal
requested review from
matthewgallo and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6400 +/- ##
==========================================
- Coverage 79.59% 79.58% -0.01%
==========================================
Files 394 394
Lines 12840 12840
Branches 4253 4253
==========================================
- Hits 10220 10219 -1
- Misses 2620 2621 +1
|
matthewgallo
approved these changes
Nov 12, 2024
davidmenendez
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 13, 2024
a11d036
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6345
Change the
portalTargettype fromReactNodetoHTMLElementWhat did you change?
Changed type
ReactNodetoHTMLElementHow did you test and verify your work?
yarn avtyarn testStorybook