Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tearsheet.portalTarget declaration wrong #6345

Closed
2 tasks done
wkeese opened this issue Nov 1, 2024 · 0 comments · Fixed by #6400
Closed
2 tasks done

Tearsheet.portalTarget declaration wrong #6345

wkeese opened this issue Nov 1, 2024 · 0 comments · Fixed by #6400
Assignees
Labels
area: typescript component: Tearsheet Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working

Comments

@wkeese
Copy link
Contributor

wkeese commented Nov 1, 2024

Package

Carbon for IBM Products

Description

TearsheetShell.tsx defines portalTarget as a ReactNode whereas presumably it’s supposed to be Element;

/**
 * The DOM element that the tearsheet should be rendered within. Defaults to document.body.
 */
portalTarget?: ReactNode;

At the least, the description and the typescript declaration don’t seem to match.

I reported this in #5700 but it was closed without this problem being fixed, hence I need to repeat the ticket.

Component(s) impacted

Tearsheet, TearsheetShell, TearsheetNarrow

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.45

Suggested Severity

None

Product/offering

IKC

CodeSandbox or Stackblitz example

N/A

Steps to reproduce the issue (if applicable)

N/A

Release date (if applicable)

No response

Code of Conduct

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Nov 1, 2024
@amal-k-joy amal-k-joy added type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. and removed status: needs triage 🕵️‍♀️ labels Nov 11, 2024
@amal-k-joy amal-k-joy moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript component: Tearsheet Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: bug 🐛 Something isn't working
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

4 participants