Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditionBuilder): release review changes1 #6133

Merged

Conversation

amal-k-joy
Copy link
Contributor

Closes #6124

Fixes for release review comments by Afsal

  • Flickering while hovering the close Delete Condition button
  • In Firefox, when pressing Esc to close the Date Picker, it toggles the fullscreen. (preventDefault)
  • Remove unwanted comments
  • Error in console when pressing up and down arrows in the Price field
  • Escape button click not closing popover when search input is focussed
    -Refactored keypress event logic for popover

How did you test and verify your work?

storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner September 27, 2024 08:35
@amal-k-joy amal-k-joy requested review from elycheea, matthewgallo and makafsal and removed request for a team September 27, 2024 08:35
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 332d12c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/671623daa4a9630008e32ac5
😎 Deploy Preview https://deploy-preview-6133--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@makafsal makafsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devadula-nandan devadula-nandan self-requested a review October 21, 2024 09:48
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 332d12c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/671623daa7c7b100082c0d71
😎 Deploy Preview https://deploy-preview-6133--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea added this pull request to the merge queue Oct 21, 2024
Merged via the queue into carbon-design-system:main with commit d3f08bc Oct 21, 2024
27 checks passed
@amal-k-joy amal-k-joy added the hacktoberfest https://hacktoberfest.com/ label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition builder initial release review issues
5 participants