Skip to content

Commit

Permalink
Merge branch 'main' into conditionbuilderReleaseReview1
Browse files Browse the repository at this point in the history
  • Loading branch information
devadula-nandan authored Oct 21, 2024
2 parents fa47b28 + 95c6489 commit 332d12c
Show file tree
Hide file tree
Showing 464 changed files with 12,064 additions and 1,147 deletions.
30 changes: 30 additions & 0 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
coverage:
status:
project:
default:
informational: true
patch:
default:
informational: true

# This is the configuration on how the codecov report layout will look like in PR's
comment:
layout: 'header, diff, flags, components'

component_management:
default_rules:
statuses:
- type: project
target: auto
threshold: 1%
branches:
- '!main'
individual_components:
- component_id: ibm-products
name: ibm-products
paths:
- ../packages/ibm-products/**
- component_id: ibm-products-web-components
name: ibm-products-web-components
paths:
- ../packages/ibm-products-web-components/**
15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,14 @@ jobs:
- name: Install
run: yarn
- name: CI tests for c4p
run: yarn ci-check:test:c4p
run: yarn ci-check:test:c4p --collectCoverage
- name: Upload coverage reports to Codecov with GitHub Action
uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
- name: CI snapshot tests for c4p
run: yarn ci-check:test:c4p:snapshot
test-community:
test-c4p-wc:
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -110,12 +114,11 @@ jobs:
with:
path: '**/node_modules'
key:
test-community-modules-${{ runner.os }}-${{ hashFiles('yarn.lock')
}}
test-c4p-wc-modules-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- name: Install
run: yarn
- name: CI tests for community
run: yarn ci-check:test:community
- name: CI tests for products web components
run: yarn ci-check:test:c4p-wc

avt-runner:
strategy:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release-v1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: v1 release # Builds and releases @carbon/v10 supported version of @carbon/

on:
workflow_dispatch:
schedule:
- cron: '30 4 * * TUE' # Release every Tuesday at 4:30am EST

jobs:
Release_v1:
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
[![Netlify status](https://img.shields.io/netlify/e8cd9972-0fc8-4c51-a911-e9a930ca6605)](https://app.netlify.com/sites/carbon-for-ibm-products/deploys)
[![GitHub Lerna version](https://img.shields.io/github/lerna-json/v/carbon-design-system/ibm-products)](https://lerna.js.org)
[![PRs welcome](https://img.shields.io/badge/PRs-welcome-brightgreen)](https://github.com/carbon-design-system/ibm-products/blob/master/.github/CONTRIBUTING.md)
[![codecov](https://codecov.io/gh/carbon-design-system/ibm-products/graph/badge.svg?token=TKEL92HSUK)](https://codecov.io/gh/carbon-design-system/ibm-products)

## 🚀 Getting started

Expand Down
22 changes: 22 additions & 0 deletions config/jest-config-ibm-cloud-cognitive/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,28 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.11.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-10-14)


### Bug Fixes

* adds html output for coverage reporting ([#6150](https://github.com/carbon-design-system/ibm-products/issues/6150)) ([beaa94c](https://github.com/carbon-design-system/ibm-products/commit/beaa94c98a2df75f6773d810726fe1b6522658d2))
* adds typescript to coverage report ([#6140](https://github.com/carbon-design-system/ibm-products/issues/6140)) ([2466c5b](https://github.com/carbon-design-system/ibm-products/commit/2466c5bb001f18ad065eb669f380cd32db0d0bfc))
* temp workaround for target_spacing_sufficient rule ([#6166](https://github.com/carbon-design-system/ibm-products/issues/6166)) ([314a6d8](https://github.com/carbon-design-system/ibm-products/commit/314a6d835bc5335d750392156c6fbcdff25db85b))
* update toHaveNoAxeViolations and remove skips ([#5955](https://github.com/carbon-design-system/ibm-products/issues/5955)) ([694128b](https://github.com/carbon-design-system/ibm-products/commit/694128bb707a2400d67e6618af3fea3f3ffba86f))





# [1.10.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-10-09)

**Note:** Version bump only for package jest-config-ibm-cloud-cognitive





# [1.10.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-09-30)


Expand Down
9 changes: 8 additions & 1 deletion config/jest-config-ibm-cloud-cognitive/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@
'use strict';

module.exports = {
collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}', '!**/*.stories.{js,jsx}'],
coverageReporters: ['json', 'html'],
collectCoverageFrom: [
'src/**/*.{js,jsx,ts,tsx}',
'!**/*.stories.{js,jsx}',
'!**/*.story.{js,jsx}',
'!**/*.docs-page.{js,jsx}',
],
coveragePathIgnorePatterns: ['preview-components'],
resolver: require.resolve('./setup/resolver.js'),
moduleFileExtensions: ['tsx', 'ts', 'jsx', 'js', 'json', 'node'],
moduleNameMapper: {
Expand Down
2 changes: 1 addition & 1 deletion config/jest-config-ibm-cloud-cognitive/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jest-config-ibm-cloud-cognitive",
"private": true,
"version": "1.10.0-rc.0",
"version": "1.11.0-rc.0",
"license": "Apache-2.0",
"main": "index.js",
"repository": {
Expand Down
9 changes: 9 additions & 0 deletions config/storybook-addon-carbon-theme/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,12 @@ $feature-flags: (
);
}
```

## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry

This package uses IBM Telemetry to collect de-identified and anonymized metrics
data. By installing this package as a dependency you are agreeing to telemetry
collection. To opt out, see
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
For more information on the data being collected, please see the
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).
2 changes: 1 addition & 1 deletion config/storybook-addon-carbon-theme/telemetry.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# yaml-language-server: $schema=https://unpkg.com/@ibm/telemetry-config-schema@v1/dist/config.schema.json
version: 1
projectId: '55e814ff-85db-406f-9e37-2d0c92a753b0'
endpoint: 'https://collector-prod.1am6wm210aow.us-south.codeengine.appdomain.cloud/v1/metrics'
endpoint: 'https://www-api.ibm.com/ibm-telemetry/v1/metrics'
collect:
npm:
dependencies: null
Expand Down
25 changes: 21 additions & 4 deletions cspell.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"version": "0.1",
"language": "en",
"dictionaries": ["contributors", "html", "packages"],
"dictionaries": [
"contributors",
"html",
"packages"
],
"dictionaryDefinitions": [
{
"name": "contributors",
Expand Down Expand Up @@ -69,10 +73,12 @@
"apikeymodal",
"autodocs",
"automerge",
"beingclosed",
"bugsquash",
"buildhome",
"callout",
"checkmark",
"clazz",
"coachmark",
"coachmarks",
"codemods",
Expand All @@ -82,6 +88,8 @@
"combobox",
"combobutton",
"createmodal",
"cssnano",
"csspart",
"csstools",
"dasharray",
"data-testid",
Expand All @@ -91,17 +99,18 @@
"disttags",
"dragbar",
"draggable",
"interstitialscreenviewmodule",
"draghandle",
"dragmode",
"editinplace",
"editsidepanel",
"emptystate",
"erroremptystate",
"explainability",
"exportmodal",
"expressivecard",
"fieldsets",
"focusable",
"formdata",
"fullpageerror",
"gridcell",
"guidebanner",
Expand All @@ -110,15 +119,20 @@
"homescreen",
"httperror",
"httperrorother",
"interstitialscreenview",
"importmodal",
"inlineedit",
"noninteractive",
"inlinetip",
"interstitialscreenview",
"interstitialscreenviewmodule",
"jsnext",
"listbox",
"loglevel",
"Menlo",
"mordech",
"namor",
"Neue",
"nodataemptystate",
"noninteractive",
"nonlinearreading",
"nonselectablerows",
"noreply",
Expand All @@ -127,6 +141,7 @@
"overscroll",
"pageload",
"pconsole",
"pluginutils",
"posinset",
"Prefs",
"preid",
Expand All @@ -152,6 +167,7 @@
"setsize",
"sidepanel",
"skipnav",
"slotchange",
"spacebar",
"stackable",
"stackblitz",
Expand All @@ -176,6 +192,7 @@
"toolbarbutton",
"treegrid",
"treeview",
"tsickle",
"typeahead",
"typeof",
"unauthorizedemptystate",
Expand Down
103 changes: 103 additions & 0 deletions e2e/components/CreateFlows/CreateTearsheet-test.avt.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,107 @@ test.describe('CreateTearsheet @avt', () => {
'CreateTearsheet @avt-default-state'
);
});

test('@avt-focus-move-properly-across-steps', async ({ page }) => {
await visitStory(page, {
component: 'CreateTearsheet',
id: 'ibm-products-patterns-create-flows-createtearsheet--multi-step-tearsheet',
globals: {
carbonTheme: 'white',
},
});

const modalElement = page.locator(`.${carbon.prefix}--modal.is-visible`);
// Pressing 'Tab' key to focus on the "Open CreateTearsheet" button in the Storybook
await page.keyboard.press('Tab');
// Pressing 'Enter' key to open the Tearsheet
await page.keyboard.press('Enter');

await expect(modalElement).toBeVisible();
await modalElement.evaluate((element) =>
Promise.all(
element.getAnimations().map((animation) => animation.finished)
)
);

const learnMoreAnchor = page.getByText('Learn more.');
const step1Input1 = page.locator(
'#tearsheet-multi-step-story-text-input-multi-step-1'
);
const nextButton = page.getByText('Next');
const backButton = page.getByText('Back');
// Expect the Learn More link to be focused
await expect(learnMoreAnchor).toBeFocused();

// Switch focus to input box
await page.keyboard.press('Tab');
// Expect the input box to be focused
await expect(step1Input1).toBeFocused();

// Type some text in the input field
await page.keyboard.type('H');
// Expect the Next button to be enabled at this moment
await expect(nextButton).toBeEnabled();

// Switch focus to next button
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');

// Expect next button to be focused
await expect(nextButton).toBeFocused();

// Goto next step by pressing enter
await page.keyboard.press('Enter');

const step2Input1 = page.locator('#custom-step-input');
// Expect the Step 2 input field is focused
await expect(step2Input1).toBeFocused();
// Also confirm the Next button disabled in this step
await expect(nextButton).toBeDisabled();

// Type some text in the input field
await page.keyboard.type('L');
// Expect Next button enabled now
await expect(nextButton).toBeEnabled();

// Switch focus to next button
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');

// Goto next step by pressing enter
await page.keyboard.press('Enter');

const step3Input1 = page.locator('#carbon-number');
// Expect the first input element to be focuses
await expect(step3Input1).toBeFocused();

// Switch focus to next button
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');

// Goto previous step by pressing enter
await expect(backButton).toBeFocused();
await page.keyboard.press('Enter');

// Expect the first element in the previous step to be focused
await expect(step2Input1).toBeFocused();

// Switch focus to next button
await page.keyboard.press('Tab');
await page.keyboard.press('Tab');

// Goto previous step by pressing enter
await expect(backButton).toBeFocused();
await page.keyboard.press('Enter');

// Expect the previous page first element to be focused
await expect(learnMoreAnchor).toBeFocused();
});
});
9 changes: 9 additions & 0 deletions examples/carbon-for-ibm-products/APIKeyModal/index.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
<!--
@license
Copyright IBM Corp. 2020, 2024
This source code is licensed under the Apache-2.0 license found in the
LICENSE file in the root directory of this source tree.
-->

<!DOCTYPE html>
<html lang="en">

Expand Down
2 changes: 1 addition & 1 deletion examples/carbon-for-ibm-products/APIKeyModal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"dependencies": {
"@carbon/ibm-products": "^2.21.0",
"@carbon/react": "^1.51.1",
"@carbon/react": "^1.60.3",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
Loading

0 comments on commit 332d12c

Please sign in to comment.