fix(TagSet): modal gradient #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
required when using `hasScrollingContent`
Remove override of the Carbon modal default
elycheea
requested review from
davidmenendez and
AlexanderMelox
and removed request for
a team
davidmenendez
approved these changes
Oct 7, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2024
459109d
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4359
Fixes modal scroll position. This was chilling in my branches since we discovered the about modal drama from last week. 😅
What did you change?
Adjust fade positioning although it may make more sense to usehasScrollingContent. Opening this PR as is for now since there’s a bug open onhasScrollingContentso may be better to wait to actually update this.Refactored to use
hasScrollingContentfrom the Carbon modal, which requires the addition of anaria-label. Tried to introduce it in a way that will not affect anyone already using theTagSetorTagOverflow.How did you test and verify your work?
Storybook, CI