Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll gradient in modals #4359

Open
1 of 3 tasks
elycheea opened this issue Feb 19, 2024 · 0 comments
Open
1 of 3 tasks

Fix scroll gradient in modals #4359

elycheea opened this issue Feb 19, 2024 · 0 comments
Assignees
Labels
component: modal For API key, about, export, import, remove modals type: bug 🐛 Something isn't working UX: consistency Issues leading to inconsistencies within one or across multiple experiences UX: issue Any type of experience feedback that once addressed improves or enhances the experience UX: visual Issues with styling, layout, and interaction details that are not following detailed design specs version: 2 Carbon 11 / v2

Comments

@elycheea
Copy link
Contributor

What package(s) are you using?

  • Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
  • Legacy/CDAI
  • Legacy/Security

Detailed description

Describe in detail the issue you're having.

Scroll gradient is not positioned correctly in the TagSet overflow modal. Scroll gradient is not present in AboutModal but believe that it is intended to be.

TagSet overflow AboutModal
image image

Is this issue related to a specific component?

TagSetModal, AboutModal.
These likely should just be using hasScrollingContent from the Carbon composed modal.

What did you expect to happen? What happened instead? What would you like to
see changed?

Scroll gradient should be positioned to the bottom of the TagSet modal (likely a result of not having buttons in the TagSetModal.) AboutModal should also use scrolling content when content is long.

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?
v2.26.0

Steps to reproduce the issue

  1. Navigate to TagSet story

  2. Click or activate the overflow (+xxx) to open the modal

  3. Modal should open with the scrolling overflow floating

  4. Navigate to AboutModal story

  5. Set content to long content

  6. Modal does not display a scrolling overflow

Additional information

  • Screenshots or code
  • Notes
@elycheea elycheea added type: bug 🐛 Something isn't working component: modal For API key, about, export, import, remove modals version: 2 Carbon 11 / v2 UX: issue Any type of experience feedback that once addressed improves or enhances the experience UX: visual Issues with styling, layout, and interaction details that are not following detailed design specs UX: consistency Issues leading to inconsistencies within one or across multiple experiences labels Feb 19, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Feb 19, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Feb 22, 2024
@elycheea elycheea self-assigned this Feb 22, 2024
@elycheea elycheea moved this from Needs refinement 🤓 to Backlog 🌋 in Carbon for IBM Products Feb 26, 2024
@elycheea elycheea moved this from Backlog 🌋 to In progress in Carbon for IBM Products Mar 5, 2024
@elycheea elycheea moved this from In progress to Backlog 🌋 in Carbon for IBM Products Aug 23, 2024
@elycheea elycheea moved this from Backlog 🌋 to Needs review 👋 in Carbon for IBM Products Oct 4, 2024
@elycheea elycheea moved this from Needs review 👋 to In progress in Carbon for IBM Products Oct 4, 2024
@elycheea elycheea moved this from In progress to Needs review 👋 in Carbon for IBM Products Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: modal For API key, about, export, import, remove modals type: bug 🐛 Something isn't working UX: consistency Issues leading to inconsistencies within one or across multiple experiences UX: issue Any type of experience feedback that once addressed improves or enhances the experience UX: visual Issues with styling, layout, and interaction details that are not following detailed design specs version: 2 Carbon 11 / v2
Projects
Status: Needs review 👋
Development

No branches or pull requests

1 participant