fix(sketch): add undefined exception handler in icon generate script #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Deploy preview for carbon-components-react ready! Built with commit a3d46e7 https://deploy-preview-5583--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit a3d46e7 |
joshblack
suggested changes
Mar 10, 2020
| @@ -68,18 +68,19 @@ export function generate() { | |||
| const [_type, _category, _subcategory, name, size] = parts; | |||
| return name === icon && size === '32'; | |||
| }); | |||
| const instance = symbol.createNewInstance(); | |||
| instance.frame.offset(ICON_X_OFFSET, ICON_Y_OFFSET); | |||
| const instance = symbol?.createNewInstance(); | |||
There was a problem hiding this comment.
Oh wild, I think we might want to fail if the symbol doesn't exist. Maybe something like:
if (!symbol) {
throw new Error(`Unable to find symbol for icon ${icon}`);
}
emyarod
force-pushed
the
5582-sketch-icon-generate-script-undefined-exception-handler
branch
2 times, most recently
from
5733a36 to
edb3925
Compare
joshblack
approved these changes
Mar 11, 2020
emyarod
force-pushed
the
5582-sketch-icon-generate-script-undefined-exception-handler
branch
2 times, most recently
from
b6e0784 to
3a7a807
Compare
emyarod
force-pushed
the
5582-sketch-icon-generate-script-undefined-exception-handler
branch
from
3a7a807 to
a3d46e7
Compare
emyarod
deleted the
5582-sketch-icon-generate-script-undefined-exception-handler
branch
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…arbon-design-system#5583) * chore: add log script * chore: fix typo * fix(sketch): handle undefined exception
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
… script (carbon-design-system#5583)" This reverts commit 83b766e.
renmaddox
added a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
… script (carbon-design-system#5583)" This reverts commit 83b766e.
renmaddox
pushed a commit
to renmaddox/carbon
that referenced
this pull request
Mar 20, 2020
…arbon-design-system#5583) * chore: add log script * chore: fix typo * fix(sketch): handle undefined exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5582
This PR avoid pushing
undefinedas a Layer object to Sketch in the icon page generation script and adds an npm script for viewing the development logChangelog
New
lognpm script for viewing the development logChanged
undefinedexception handler in icons/generate scriptTesting / Reviewing
carbon/packages/sketch/src/commands/icons/shared.jsto only deal with a subset of icons (either modify thestartandendvariables to be a subset of the full icons list or directly change the slice size insymbolsToSync)yarn build