fix(sketch): add undefined exception handler in icon generate script (#…

…5583) * chore: add log script * chore: fix typo * fix(sketch): handle undefined exception
carbon-design-system · Mar 19, 2020 · a301044 · a301044
1 parent 122af4a
commit a301044
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/packages/sketch/package.json b/packages/sketch/package.json
@@ -20,6 +20,7 @@
     "build": "cross-env NODE_ENV=production skpm-build",
     "clean": "rimraf carbon-elements.sketchplugin",
     "develop": "cross-env NODE_ENV=development skpm-build --watch",
+    "log": "skpm log -f",
     "skpm:link": "skpm-link"
   },
   "dependencies": {

diff --git a/packages/sketch/src/commands/command.js b/packages/sketch/src/commands/command.js
@@ -22,7 +22,7 @@ export function command(name, fn) {
     sketch.UI.message('Done! 🎉');
   } catch (error) {
     console.log(error);
-    sketch.UI.message('An error occured, please check the development logs');
+    sketch.UI.message('An error occurred, please check the development logs');
   }
 
   if (process.env.NODE_ENV === 'development') {

diff --git a/packages/sketch/src/commands/icons/generate.js b/packages/sketch/src/commands/icons/generate.js
@@ -68,6 +68,11 @@ export function generate() {
             const [_type, _category, _subcategory, name, size] = parts;
             return name === icon && size === '32';
           });
+
+          if (!symbol) {
+            throw new Error(`Unable to find symbol for icon ${icon}!`);
+          }
+
           const instance = symbol.createNewInstance();
           instance.frame.offset(ICON_X_OFFSET, ICON_Y_OFFSET);