fix(tag): add filter tag keyboard navigation #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
2474-filter-tag-close-has-no-keyboard-interaction-or-focus-state
branch
from
61486bc to
e6bccae
Compare
|
Deploy preview for the-carbon-components ready! Built with commit 731f037 https://deploy-preview-2654--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 731f037 https://deploy-preview-2654--carbon-components-react.netlify.com |
joshblack
approved these changes
May 13, 2019
tw15egan
approved these changes
May 13, 2019
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
@emyarod Would you be able to solve the merge conflict...? Thanks! |
emyarod
force-pushed
the
2474-filter-tag-close-has-no-keyboard-interaction-or-focus-state
branch
from
e6bccae to
731f037
Compare
emyarod
deleted the
2474-filter-tag-close-has-no-keyboard-interaction-or-focus-state
branch
This was referenced Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2474
This PR adds keyboard navigation to the filter tag. When focused, the filter tag will appear as though it is hovered
Changelog
New
disabledstorybook knob