Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect clear button interactive styles #2918

Closed
1 of 2 tasks
diego-codes opened this issue Jun 4, 2019 · 6 comments · Fixed by #2936
Closed
1 of 2 tasks

MultiSelect clear button interactive styles #2918

diego-codes opened this issue Jun 4, 2019 · 6 comments · Fixed by #2936
Assignees
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@diego-codes
Copy link
Contributor

diego-codes commented Jun 4, 2019

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

As a mostly keyboard-only user, when I tab through the MultiSelect component, the clear selections button does not have sufficient focus (or even hover) style differences to make it clear that holds the keyboard focus.

Is this issue related to a specific component?

Yes, the MultiSelect

What did you expect to happen? What happened instead? What would you like to
see changed?

I think it would improve the usability of this component to provide better focus and hover styles to the clear selections button.

What version of the Carbon Design System are you using?

10.x

Additional information

Tabbing through MultiSelect
Kapture 2019-06-04 at 8 56 05

@dakahn dakahn added package: react carbon-components-react type: a11y ♿ labels Jun 4, 2019
@dakahn dakahn added severity: 1 https://ibm.biz/carbon-severity priority: medium labels Jun 4, 2019
@dakahn
Copy link
Contributor

dakahn commented Jun 4, 2019

Totally great catch. I'll ping @carbon-design-system/design and we can get a PR going based on their specs.

@emyarod emyarod self-assigned this Jun 5, 2019
@emyarod
Copy link
Member

emyarod commented Jun 5, 2019

related #2360 #2654

@aagonzales
Copy link
Member

So we're looking for a hover and focus style for the tag?

@asudoh
Copy link
Contributor

asudoh commented Jun 6, 2019

I think it's only about focus-style. @emyarod @diego-codes correct me if I'm wrong here.

@emyarod
Copy link
Member

emyarod commented Jun 6, 2019

I'm using the same style for hover and focus so depending on what we go with design wise, it could be focus only or both hover and focus

@asudoh
Copy link
Contributor

asudoh commented Jun 6, 2019

OK added @aagonzales as a reviewer for #2936 - @aagonzales Please feel free to delegate in case another designer should review - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants