[web-components]: deprecate side-panel and tearsheet components
#17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/wc-deprecate-side-panel-tearsheet
kennylam
requested review from
alisonjoseph,
guidari,
emyarod,
ariellalgilmore and
annawen1
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17772 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 406 406
Lines 14019 14019
Branches 4388 4356 -32
=======================================
Hits 11154 11154
Misses 2699 2699
Partials 166 166 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Oct 16, 2024
| @@ -67,7 +67,6 @@ | |||
| "wca": "web-component-analyzer analyze src --outFile custom-elements.json" | |||
| }, | |||
| "dependencies": { | |||
| "@carbon/ibm-products-styles": "^2.30.1", | |||
Merged
via the queue into
carbon-design-system:main
with commit Oct 16, 2024
f16158e
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
side-panelandtearsheetweb components are in the process of being moved to the @carbon/ibm-products-web-components package where they will be maintained.ibm-products-web-components): setup new web component package and storybook ibm-products#6148This deprecates them in
@carbon/web-componentsand removes component-specific dependencies.Changelog
Changed
side-panelandtearsheetcomponentsside-panelandtearsheettoDeprecatedsection in Storybook and update stories to direct users to new component locationRemoved
@carbon/ibm-product-stylesside-panel/tearsheetstories and docsTesting / Reviewing
Confirm component stories have been moved to
Deprecatedsection in Storybook and that each component story has instructions to their new location (web components deploy preview newly added for this PR).