Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update stylelint and related deps to v16 #17770

Merged
merged 14 commits into from
Oct 18, 2024

Conversation

2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Oct 16, 2024

Closes #16604

Migrated to Stylelint 16.0.0
Adjusted the stylelint-config-carbon package to reflect changes in accessibility rules.
Converted all relevant code from CommonJS to ESModules
Removed Deprecated Rule Sets
Removed Unnecessary Disabled Rules
Reference PR- #16617

Testing / Reviewing

yarn lint:styles

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7fde43f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670fe907e4c50800089cc4fc
😎 Deploy Preview https://deploy-preview-17770--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7fde43f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670fe907a056730008a251a3
😎 Deploy Preview https://deploy-preview-17770--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0313b53
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6712345ce9f4760008cbacef
😎 Deploy Preview https://deploy-preview-17770--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0313b53
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6712345c07566d0008a6286f
😎 Deploy Preview https://deploy-preview-17770--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (4312ae4) to head (0313b53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17770   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files         406      406           
  Lines       14012    14012           
  Branches     4333     4333           
=======================================
  Hits        11171    11171           
  Misses       2676     2676           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0313b53
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6712345c9919ca00080e7bd3
😎 Deploy Preview https://deploy-preview-17770--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom 2nikhiltom marked this pull request as ready for review October 17, 2024 08:03
@2nikhiltom 2nikhiltom requested a review from a team as a code owner October 17, 2024 08:03
@2nikhiltom 2nikhiltom requested a review from kennylam October 17, 2024 08:14
@2nikhiltom
Copy link
Contributor Author

[web-components]: deprecate side-panel and tearsheet components - This PR removed the side-panel and tearsheet components

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this looks really solid! I'm very out of the loop on this one so sorry if some of the feedback here isn't valid. Let me know what you think, I'm happy to pair up on stuff if you'd like.

packages/styles/scss/_reset.scss Show resolved Hide resolved
packages/web-components/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/styles/scss/components/tag/_tag.scss Show resolved Hide resolved
packages/styles/scss/components/popover/_popover.scss Outdated Show resolved Hide resolved
config/stylelint-config-carbon/package.json Show resolved Hide resolved
config/stylelint-config-carbon/rules/stylistic-issues.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/grid/scss/_css-grid.scss Outdated Show resolved Hide resolved
@tay1orjones tay1orjones changed the title ci: stylelint16_upgrade fix(deps): update stylelint and related deps to v16 Oct 17, 2024
@2nikhiltom
Copy link
Contributor Author

Hey @tay1orjones ! Thank you for the detailed review and for pairing up on this, made the necessary changes to be reviewed

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kennylam kennylam added status: ready to merge 🎉 dependencies Pull requests that update a dependency file labels Oct 18, 2024
@kennylam kennylam added this pull request to the merge queue Oct 18, 2024
Merged via the queue into carbon-design-system:main with commit e96c686 Oct 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status: ready to merge 🎉
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update stylelint-config-carbon for Stylelint 16
3 participants