-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update stylelint and related deps to v16 #17770
fix(deps): update stylelint and related deps to v16 #17770
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17770 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 406 406
Lines 14012 14012
Branches 4333 4333
=======================================
Hits 11171 11171
Misses 2676 2676
Partials 165 165 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[web-components]: deprecate side-panel and tearsheet components - This PR removed the side-panel and tearsheet components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this looks really solid! I'm very out of the loop on this one so sorry if some of the feedback here isn't valid. Let me know what you think, I'm happy to pair up on stuff if you'd like.
Hey @tay1orjones ! Thank you for the detailed review and for pairing up on this, made the necessary changes to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
e96c686
Closes #16604
Migrated to
Stylelint 16.0.0
Adjusted the
stylelint-config-carbon
package to reflect changes in accessibility rules.Converted all relevant code from
CommonJS
toESModules
Removed Deprecated Rule Sets
Removed Unnecessary Disabled Rules
Reference PR- #16617
Testing / Reviewing
yarn lint:styles