Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit test] - Dismissible Tag #17716

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 10, 2024

Closes #17504

Added tests for dismissible tag
We are gonna remove slug in this #17706, so we don't have to cover that part

Testing / Reviewing

  • Test should be at 95.23

@guidari guidari requested a review from a team as a code owner October 10, 2024 18:16
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6b72eae
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670d10fa6d980200081507f9
😎 Deploy Preview https://deploy-preview-17716--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b72eae
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670d10fa8141340007067005
😎 Deploy Preview https://deploy-preview-17716--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (32c8bef) to head (6b72eae).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17716      +/-   ##
==========================================
+ Coverage   79.09%   79.11%   +0.02%     
==========================================
  Files         407      407              
  Lines       14029    14029              
  Branches     4358     4390      +32     
==========================================
+ Hits        11096    11099       +3     
+ Misses       2767     2764       -3     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit 99db933 Oct 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase DismissibleTag unit test coverage
3 participants