Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Interactive Tags to stable #17706

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 9, 2024

Closes #17694

  • Move Interactive Tags under Tag in storybook.
  • Removed slug from Interactive Tags.
  • Removed Playground story and added controls to Read Only story.
  • Changed Overview page.

Testing / Reviewing

  • All stories should work

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9ca6938
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670d54f3b4a16c0008f979ad
😎 Deploy Preview https://deploy-preview-17706--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ca6938
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670d54f3a979ba0008f58b91
😎 Deploy Preview https://deploy-preview-17706--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari requested a review from a team as a code owner October 10, 2024 12:01
@guidari guidari requested a review from alisonjoseph October 10, 2024 12:01
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (9d1822c) to head (9ca6938).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17706      +/-   ##
==========================================
+ Coverage   78.33%   79.31%   +0.97%     
==========================================
  Files         408      406       -2     
  Lines       14015    14019       +4     
  Branches     4324     4384      +60     
==========================================
+ Hits        10979    11119     +140     
+ Misses       2868     2734     -134     
+ Partials      168      166       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guidari guidari changed the title WIP: Moving Interactive Tags to stable Moving Interactive Tags to stable Oct 11, 2024
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidari guidari requested a review from aagonzales October 14, 2024 17:51
@kennylam kennylam added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit 781bfed Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Interactive Tags to stable
4 participants