fix(datatable): set overflowMenuOnHover to false

[mranjana]

Closes #15480

DataTable overflowMenuOnHover set to false default

Changelog

Changed

• changed overflowMenuOnHover to false

Testing / Reviewing

{{ DataTable overflowMenu}}

[github-actions]

DCO Assistant Lite bot All contributors have signed the DCO.

[netlify]

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	88d06a0
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/65f3dd465196010009fc652d
😎 Deploy Preview	https://deploy-preview-15909--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mranjana]

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

You can retrigger this bot by commenting recheck in this Pull Request

I have read the DCO document and I hereby sign the DCO.

[mranjana]

recheck

[mranjana]

I have read the DCO document and I hereby sign the DCO.

[alisonjoseph]

I believe this change should only be made in the example in storybook not in the actual component. (this would be a breaking change otherwise)
https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/DataTable/stories/DataTable-toolbar.stories.js#L227

[alisonjoseph]

LGTM! Thanks!

[tw15egan]

@alisonjoseph, Based on the discussion, it seems like this is intentional #15480 (comment)

@tay1orjones is this still the desired outcome?

[alisonjoseph]

Seems like this change is correct based on @tay1orjones last comment?

After discussing further, the determination is this will just be changing overflowMenuOnHover to be false by default. It's already mentioned on the website to be this way, so this unifies the implementation against the current documentation. This isn't new design guidance either, it's been present for quite a while on the website.

[tw15egan]

@alisonjoseph, my understanding was that this is to unite the website documentation and the default value of the prop with the storybook. On the website we state:

By default, the overflow menu icons are persistent on each row. Having the overflow menus always visible signals to the user actions can be taken on the table rows. Alternatively, a product team may use the overflowMenuOnHover prop to only show the overflow menu on hover and focus to reduce the visual clutter of an overflow menu on every row.

So it sounds like we should set overflowMenuOnHover to false by default so that they are all persistent

[alisonjoseph]

@tw15egan I think we are saying the same thing, this PR does set overflowMenuOnHover to false, which means it shows by default. The prop name is confusing.

[tw15egan]

@alisonjoseph It sounded like we wanted to set the default value of this prop to false, not just the storybook story. The reason for that is @tay1orjones comments about this not being considered a breaking change:

We think this does not constitute a breaking change because:

• This is a meaningful improvement to usability and accessibility for all users
• It has a relatively low surface area and should not impact existing application test harnesses
• overflowMenuOnHover remains configurable - consumers can set it to true if they prefer the old functionality

The original PR commit is the change I was expecting

[alisonjoseph]

ohhh @tw15egan I completely misunderstood the original issue then.

[alisonjoseph]

LGTM! SO sorry for the confusion with this. Thanks for the contribution!

[tw15egan]

LGTM 👍 ✅