Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Data Table Implementation (Overflow menu) #15480

Closed
Kritvi-bhatia opened this issue Jan 2, 2024 · 7 comments · Fixed by #15909
Closed

[Dev] Data Table Implementation (Overflow menu) #15480

Kritvi-bhatia opened this issue Jan 2, 2024 · 7 comments · Fixed by #15909
Assignees
Milestone

Comments

@Kritvi-bhatia
Copy link

Kritvi-bhatia commented Jan 2, 2024

"By default, the overflow menu icons are persistent on each row. Having the overflow menus always visible signals to the user actions can be taken on the table rows. Alternatively, a product team may use the overflowMenuOnHover prop to only show the overflow menu on hover and focus to reduce the visual clutter of an overflow menu on every row"
Source

TO BE UPDATED : In the storybook, by default state should be the menu icons are persistent on each row.

Currently, we can add this under feature flag.

CURRENT STATE : Currently, we're having the over flow menu hover state as by default.
image


References:

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@sstrubberg sstrubberg moved this from Triage to Next in Roadmap Jan 8, 2024
@sstrubberg sstrubberg changed the title Update Data Table Component Selectable Components: DataTable implementation Jan 10, 2024
@tay1orjones
Copy link
Member

@Kritvi-bhatia This can currently be done with the overflowMenuOnHover prop. Here's an example, you can configure the controls to toggle the prop.

I think we can close this issue unless we want to mandate this change to always be visible. If we want it to be a configurable option like it already is, I think we can close this one.

@tay1orjones
Copy link
Member

After discussing further, the determination is this will just be changing overflowMenuOnHover to be false by default. It's already mentioned on the website to be this way, so this unifies the implementation against the current documentation. This isn't new design guidance either, it's been present for quite a while on the website.

We think this does not constitute a breaking change because:

  • This is a meaningful improvement to usability and accessibility for all users
  • It has a relatively low surface area and should not impact existing application test harnesses
  • overflowMenuOnHover remains configurable - consumers can set it to true if they prefer the old functionality

@Kritvi-bhatia
Copy link
Author

HI @tay1orjones, can you please help me understand what is this "persistent" boolean is for?
image

@Kritvi-bhatia Kritvi-bhatia changed the title Selectable Components: DataTable implementation [Dev] Data Table Implementation: Selectable Component Jan 12, 2024
@Kritvi-bhatia Kritvi-bhatia changed the title [Dev] Data Table Implementation: Selectable Component [Dev] Data Table Implementation (Overflow menu) Jan 25, 2024
@guidari
Copy link
Contributor

guidari commented Feb 9, 2024

Hey @Kritvi-bhatia17
The persistent prop makes the search functionality not expandable and persistent.

Example: https://react.carbondesignsystem.com/?path=/story/components-datatable-toolbar--persistent-toolbar

@guidari guidari added the good first issue 👋 Used by GitHub to elevate contribution opportunities label Feb 9, 2024
@mranjana
Copy link
Contributor

mranjana commented Mar 4, 2024

hi @guidari , Can i work on this?

@guidari
Copy link
Contributor

guidari commented Mar 4, 2024

Sure @mranjana I'll assign you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants