Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable-BatchAction): resolve batch action button alignment #14384

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

punnoosewilson
Copy link
Member

@punnoosewilson punnoosewilson commented Aug 3, 2023

Closes #14312

The TableBatchActions inside TableToolbar are misaligned for size variant 'sm'.

Changelog

Changed

  • updated the buttons styles (padding-top and padding-bottom) for 'sm' variant.

Testing / Reviewing

checked manually through storybook.

https://deploy-preview-14384--carbon-components-react.netlify.app/?path=/story/components-datatable-batch-actions--playground&args=size:sm

@punnoosewilson punnoosewilson requested a review from a team as a code owner August 3, 2023 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@punnoosewilson
Copy link
Member Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 723807e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64cb82fcd153f30008a7afa0
😎 Deploy Preview https://deploy-preview-14384--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 723807e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64cb82fc21892d0008eb7c08
😎 Deploy Preview https://deploy-preview-14384--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙌

@alisonjoseph alisonjoseph requested review from a team and aagonzales and removed request for a team August 3, 2023 14:39
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating!

@tw15egan tw15egan added this pull request to the merge queue Aug 4, 2023
Merged via the queue into carbon-design-system:main with commit 449b1bf Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Table batch actions styling is broken
4 participants