Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for DataTable #14149

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Add types for DataTable #14149

merged 7 commits into from
Jul 10, 2023

Conversation

djragsdale
Copy link
Contributor

Add TypeScript types for the DataTable component. Converted DataTable/DataTable.js to tsx.

Closes #12515

Changelog

New

  • Added types for DataTable props
  • DataTableCell interface
  • DataTableHeader interface
  • DataTableRenderProps interface
  • DataTableRow interface
  • DataTableSize type

Changed

  • Renamed DataTable/DataTable.js to DataTable/DataTable.tsx

Testing / Reviewing

You can check this by confirming that there are no errors when:

  • building
  • viewing the DataTable stories
  • creating a component that uses DataTable and testing which props are valid/invalid

@djragsdale
feat(react): add DataTable types
cf46588 
Add TypeScript types for the DataTable component for better developer experience

Closes #12515
@djragsdale djragsdale requested a review from a team as a code owner July 6, 2023 21:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@djragsdale
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 2e204a7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64ac065797852d00086e1ba5
😎 Deploy Preview https://deploy-preview-14149--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2e204a7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ac065788aea70008ae1a03
😎 Deploy Preview https://deploy-preview-14149--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djragsdale djragsdale mentioned this pull request Jul 6, 2023
Closed
francinelucca
francinelucca approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@kodiakhq kodiakhq bot merged commit ab058a3 into carbon-design-system:main Jul 10, 2023
@wkeese wkeese mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: one more review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to DataTable
4 participants
@djragsdale @alisonjoseph @francinelucca @andreancardona