Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to DataTable #12515

Closed
Tracked by #12513
tay1orjones opened this issue Nov 7, 2022 · 3 comments · Fixed by #14149
Closed
Tracked by #12513

Add TypeScript types to DataTable #12515

tay1orjones opened this issue Nov 7, 2022 · 3 comments · Fixed by #14149
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Nov 7, 2022
Closed
@tay1orjones tay1orjones added role: dev 🤖 area: typescript status: help wanted 👐 hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Nov 7, 2022
@mbarrer
Copy link
Contributor

mbarrer commented Feb 21, 2023

Starting work on this one

@mbarrer
Copy link
Contributor

mbarrer commented Feb 21, 2023 •
edited
Loading

After working through this one a bit, its probably better to start with the smaller table components first as this component will reference types found in these smaller components. Switching to work on another table component

@djragsdale djragsdale mentioned this issue Jul 6, 2023
Merged
@djragsdale
Copy link
Contributor

djragsdale commented Jul 6, 2023 •
edited
Loading

There's only a few related components yet to be upgraded to TS. I went ahead and took a go of it in #14149, attempting to change as little as possible within the actual code. Not having the renderProps defined was getting particularly frustrating. I also added a few nested interfaces that can be easily applied in custom state managers, such as DataTableRow and DataTableCell.

@kodiakhq kodiakhq bot closed this as completed in #14149 Jul 10, 2023
kodiakhq bot pushed a commit that referenced this issue Jul 10, 2023
@djragsdale @francinelucca @andreancardona
Add types for DataTable (#14149)
ab058a3 
* feat(react): add DataTable types

Add TypeScript types for the DataTable component for better developer experience

Closes #12515

* fix: format & lint

---------

Co-authored-by: Francine Lucca <[email protected]>
Co-authored-by: Francine Lucca <[email protected]>
Co-authored-by: Andrea N. Cardona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types for DataTable
3 participants
@tay1orjones @djragsdale @mbarrer