-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): fix issue with font-family inheritence in reset.scss #13873
fix(styles): fix issue with font-family inheritence in reset.scss #13873
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Computed styles for the button in chrome show IBM Plex being inherited 👍
Kudos for figuring this one out! I took a brief look at it when it was first reported and was ultra confused why it was happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and looks good!
Closes #13422
Fixes an issue that was causing non-carbon elements to render browser default fonts. This ports over a change from the v10 branch that is not present in the v11 branch, and resolves the issue.
button
should now inheritIBM Plex Sans
frombody
Changelog
Changed
font-family
inheritance issue in v11Testing / Reviewing
Check out the
Button --> Test
story and ensure all rendered text is inheritingIBM Plex Sans
instead ofArial
. Will remove the story once approved.