Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix issue with font-family inheritence in reset.scss #13873

Merged
merged 4 commits into from
May 31, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #13422

Fixes an issue that was causing non-carbon elements to render browser default fonts. This ports over a change from the v10 branch that is not present in the v11 branch, and resolves the issue. button should now inherit IBM Plex Sans from body

Changelog

Changed

  • Ported over a reset fix from the v10 branch to fix the font-family inheritance issue in v11

Testing / Reviewing

Check out the Button --> Test story and ensure all rendered text is inheriting IBM Plex Sans instead of Arial. Will remove the story once approved.

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2fd4bf5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/647765eb08c92e0008546d99
😎 Deploy Preview https://deploy-preview-13873--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2fd4bf5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/647765eb2df32a0008c0f206
😎 Deploy Preview https://deploy-preview-13873--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Computed styles for the button in chrome show IBM Plex being inherited 👍

Kudos for figuring this one out! I took a brief look at it when it was first reported and was ultra confused why it was happening.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and looks good!

@kodiakhq kodiakhq bot merged commit 33b35df into carbon-design-system:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HTML elements (button, div) do not inherit font-family in v11
3 participants