Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HTML elements (button, div) do not inherit font-family in v11 #13422

Closed
2 tasks done
justindm234 opened this issue Mar 29, 2023 · 1 comment · Fixed by #13873
Closed
2 tasks done

[Bug]: HTML elements (button, div) do not inherit font-family in v11 #13422

justindm234 opened this issue Mar 29, 2023 · 1 comment · Fixed by #13873
Assignees
Labels
package: styles @carbon/styles role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@justindm234
Copy link

Package

@carbon/react

Browser

Chrome, Firefox

Package version

11.25.0

React version

17.0.0

Description

In v10, HTML elements like buttons and divs inherited their font-family from the BODY (I think via _css--reset.scss). This could be seen by inspecting an element's "Rendered Fonts" in Chrome's DevTools. In v11, HTML elements no longer inherit their font-family from BODY; instead the browser (user agent stylesheet) default is applied (Arial in Chrome).

v10 example
v11 failure

Reproduction/example

v10 - https://codesandbox.io/s/reset-font-family--carbon-10-10infd v 11 - https://codesandbox.io/s/reset-font-family--carbon-11-e0m5k0

Steps to reproduce

Render an HTML element in page that includes carbon v11's min css, DIVs and BUTTONs (and likely other HTML elements) render using the browser default font (Arial in Chrome)

Suggested Severity

Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.

Application/PAL

zSystems Hardware Management Console

Code of Conduct

@justindm234
Copy link
Author

Any update on this? The change in font-family inheritance may drive a lot of work (and potential errors) for my product's migration to v11.

@sstrubberg sstrubberg moved this to 🕵️‍♀️ Triage in Design System Apr 17, 2023
@tw15egan tw15egan moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System May 1, 2023
@tay1orjones tay1orjones assigned tw15egan and unassigned alisonjoseph May 18, 2023
@tw15egan tw15egan moved this from ⏱ Backlog to 🏗 In Progress in Design System May 24, 2023
@kodiakhq kodiakhq bot closed this as completed in #13873 May 31, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles @carbon/styles role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants