refactor(Button): convert Button component family to TypeScript #13811
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| [`${prefix}--btn--sm`]: small || size === 'sm', | ||
| [`${prefix}--btn--md`]: size === 'field' || size === 'md', |
There was a problem hiding this comment.
This could possibly be a breaking change, even if it should have been deprecated before now? thoughts @tay1orjones ?
There was a problem hiding this comment.
@tay1orjones can you comment on the above?
There was a problem hiding this comment.
@tay1orjones can you take a look?
There was a problem hiding this comment.
hey @lewandom Taylor is OOO until next week - we'll make sure to take a look early next week :)
There was a problem hiding this comment.
@lewandom Hey sorry for the delay! Yeah unfortunately we'll need to leave small in for now and mark it as deprecated.
The removal of the check for field should be fine though, that's no longer an accepted value for size
There was a problem hiding this comment.
@tay1orjones restored, please check.
lewandom
force-pushed
the
typescript-button
branch
from
3c5e950 to
f1dcd2a
Compare
|
@alisonjoseph @tay1orjones can you take another look? |
andreancardona
added
status: ready to merge 🎉
component: button
and removed
status: one more review 👀
labels
lewandom
force-pushed
the
typescript-button
branch
from
47085f2 to
72f69b1
Compare
Closes #13229
Add TypeScript typings to Button, ButtonSkeleton, DangerButton and ButtonSet components.
Changelog
Changed
Removed
Testing / Reviewing
The Button component family imports for the storybook should be valid and rendering. In a TypeScript environment, you should be able to import and reference the Button family component and its typings.