Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to ActionableNotification, ToastNotification, InlineNotification, NotificationActionButton, NotificationButton #13228

Closed
Tracked by #12513
tw15egan opened this issue Feb 24, 2023 · 3 comments · Fixed by #13621
Closed
Tracked by #12513

Add TypeScript types to ActionableNotification, ToastNotification, InlineNotification, NotificationActionButton, NotificationButton #13228

tw15egan opened this issue Feb 24, 2023 · 3 comments · Fixed by #13621
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: blocked 🙅‍♀️ status: help wanted 👐

Comments

@tw15egan
Copy link
Collaborator

No description provided.

@tw15egan tw15egan mentioned this issue Feb 24, 2023
Closed
@jsehull jsehull mentioned this issue Mar 27, 2023
Merged
@kubijo
Copy link
Contributor

kubijo commented Apr 16, 2023

I'd like to work on this

kubijo added a commit to kubijo/carbon that referenced this issue Apr 18, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
69ca027
kubijo added a commit to kubijo/carbon that referenced this issue Apr 18, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
8367c16
@kubijo kubijo mentioned this issue Apr 18, 2023
Merged
kubijo added a commit to kubijo/carbon that referenced this issue Apr 19, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
236bbff
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 20, 2023
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
0637f72
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
5076bca
@tay1orjones tay1orjones mentioned this issue Apr 21, 2023
Closed
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
dbe3f10
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
084857a
@kglickman
Copy link

We have a renderer that sets the subtitle for the notification and it works fine but we're getting an error
checkPropTypes.js:20 Warning: Failed prop type: Invalid prop subtitleof typeobjectsupplied toToastNotification, expected string.

There are many other strings in Carbon that are declared as PropTypes.node. Could the notification ones be declared that way, too?

kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
9e14a2c
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
1e0debb
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
8e3616e
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
f7e8da1
@francinelucca
Copy link
Collaborator

Confirmed we'll want to hold off on this until #13811 merges so we can extend button props

kubijo added a commit to kubijo/carbon that referenced this issue Jun 17, 2023
@kubijo
feat(xNotification): rename to tsx carbon-design-system#13228
070984c
kubijo added a commit to kubijo/carbon that referenced this issue Jun 17, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
575e019
kubijo added a commit to kubijo/carbon that referenced this issue Jun 17, 2023
@kubijo
feat(xNotification): add types carbon-design-system#13228
e4e4976
@kodiakhq kodiakhq bot closed this as completed in #13621 Jun 19, 2023
kodiakhq bot added a commit that referenced this issue Jun 19, 2023
@kubijo @andreancardona @kodiakhq
types/Notification (#13621)
a000250 
* feat(xNotification): rename to tsx #13228

* feat(xNotification): add types #13228

* Update packages/react/src/components/Notification/Notification.tsx

* Update packages/react/src/components/Notification/Notification.tsx

---------

Co-authored-by: Andrea N. Cardona <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: blocked 🙅‍♀️ status: help wanted 👐
Projects
No open projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types/Notification kubijo/carbon
5 participants
@tay1orjones @kubijo @tw15egan @kglickman @francinelucca