Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title to clear button Search #11474

Merged
merged 8 commits into from
Jun 9, 2022
Merged

feat: add title to clear button Search #11474

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e1997b
feat: add title to clear button Search
anhtuan-pham1 May 23, 2022
30105f3
feat: update title and test case
anhtuan-pham1 Jun 2, 2022
9790591
Merge branch 'main' into add-title-to-clear-button-Search
anhtuan-pham1 Jun 3, 2022
30df6a2
Merge branch 'main' into add-title-to-clear-button-Search
anhtuan-pham1 Jun 3, 2022
72c26d4
Merge branch 'main' into add-title-to-clear-button-Search
anhtuan-pham1 Jun 6, 2022
c3879ec
Merge branch 'main' into add-title-to-clear-button-Search
kodiakhq[bot] Jun 9, 2022
9e9f8c8
Merge branch 'main' into add-title-to-clear-button-Search
joshblack Jun 9, 2022
fbbdb9e
Merge branch 'main' into add-title-to-clear-button-Search
kodiakhq[bot] Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react/src/components/Search/next/Search-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ describe('Search', () => {
expect(type1).toEqual('button');
expect(type2).toEqual('button');
});

it('should have clear title', () => {
expect(btns.prop('title')).toBe('Clear search input');
});
});

describe('icons', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/components/Search/next/Search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ const Search = React.forwardRef(function Search(
className={clearClasses}
disabled={disabled}
onClick={clearInput}
title={closeButtonLabelText}
type="button">
<Close />
</button>
Expand Down