feat: add title to clear button Search #11474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abbeyhrt
approved these changes
Jun 1, 2022
joshblack
reviewed
Jun 2, 2022
| @@ -135,6 +135,7 @@ const Search = React.forwardRef(function Search( | |||
| className={clearClasses} | |||
| disabled={disabled} | |||
| onClick={clearInput} | |||
| title="Clear" | |||
There was a problem hiding this comment.
One idea for this field could be to use closeButtonLabelText which is currently being used to label the <button>.
Suggested change
| title="Clear" | |
| title={closeButtonLabelText} |
One thing we would want to make sure is that title is configurable (for example, someone could specify an alternate title) given that people could use this component in different situations or would like to localize this text 👍
There was a problem hiding this comment.
Hi @joshblack I have updated the title to title={closeButtonLabelText} and the test cases. Thanks for your recommendation.
aledavila
approved these changes
Jun 3, 2022
dakahn
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding title to clear button in Search Component. The clear button now has the same type of of title that was created in the NumberInput component.
Changed
Testing / Reviewing