Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IconButton): dynamic size prop #10339

Merged
merged 7 commits into from
Jan 5, 2022
Merged

fix(IconButton): dynamic size prop #10339

merged 7 commits into from
Jan 5, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jan 4, 2022 •
edited
Loading

closes #10293

It was hard-coded to "sm". Now it accepts a prop. Defaults to 'md'.

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9434e49

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d5bc82ba53870008a6ce7d

😎 Browse the preview: https://deploy-preview-10339--carbon-react-next.netlify.app

@sstrubberg sstrubberg marked this pull request as ready for review January 4, 2022 20:38
@sstrubberg sstrubberg requested a review from a team as a code owner January 4, 2022 20:38
@sstrubberg sstrubberg requested review from joshblack and dakahn January 4, 2022 20:38
joshblack
joshblack approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joshblack
Copy link
Contributor

@laurenmrice just wanted to double check, what sizes are allowed for IconButton? 👀

@sstrubberg sstrubberg requested a review from laurenmrice January 4, 2022 20:41
@laurenmrice
Copy link
Member

@joshblack The Icon button can be Large (48px), Medium (40px), or Small (32px).

@sstrubberg sstrubberg removed the request for review from laurenmrice January 4, 2022 20:55
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: f58d832

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d4af184e618e0007be52c5

😎 Browse the preview: https://deploy-preview-10339--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: f58d832

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d4af18a080f70009f9fc98

😎 Browse the preview: https://deploy-preview-10339--carbon-components-react.netlify.app

@sstrubberg sstrubberg requested a review from a team as a code owner January 4, 2022 21:21
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 350227b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d4b3342840bd0008547d98

😎 Browse the preview: https://deploy-preview-10339--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 350227b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d4b334ff5eba0008a54ae9

😎 Browse the preview: https://deploy-preview-10339--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9434e49

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d5bc82a080f7000915b61b

😎 Browse the preview: https://deploy-preview-10339--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9434e49

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d5bc827ac1900007be1eb8

😎 Browse the preview: https://deploy-preview-10339--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻 ✅

@sstrubberg sstrubberg enabled auto-merge (squash) January 5, 2022 16:01
@sstrubberg sstrubberg merged commit 8944cac into carbon-design-system:main Jan 5, 2022
@sstrubberg sstrubberg deleted the issue-10293-size-prop branch January 5, 2022 16:43
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
@tay1orjones tay1orjones mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn Awaiting requested review from dakahn dakahn was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add size prop to IconButton and correctly forward it to Button
4 participants
@sstrubberg @joshblack @laurenmrice @tw15egan