[Bug]: IconButton size prop default should be lg
#13423
Assignees
Labels
Comments
janhassel
added a commit
to janhassel/carbon
that referenced
this issue
Mar 29, 2023
kodiakhq bot
added a commit
that referenced
this issue
Jun 2, 2023
* chore: rename Layout folder into LayoutDirection * feat: build contextual layout poc * docs: add layoutSize and layoutDensity controls to storybook * chore(contained-list): migrate to contextual layout tokens * chore(content-switcher): migrate to contextual layout tokens * feat(contextual-layout-tokens): add support for redefinition * chore(tag): migrate to contextual layout tokens * feat(contextual-layout-tokens): support multiple properties per group * docs(styles): add contextual layout tokens * chore(button): migrate to contextual layout tokens * docs(contextual-layout-tokens): add reference * chore(icon-button): migrate to contextual layout tokens * fix(code-snippet): adjust style overrides for icon button * docs(contextual-layout-tokens): add sass helper outputs * fix(contained-list): adjust padding-block based on line-height * fix(code-snippet): adjust copy-button overrides * fix(file-uploader): emit layout size * docs(contextual-layout-tokens): add docs to Layout story * fix(code-snippet): pass correct size * docs(contained-list): fix stories * fix(icon-button): make default lg ref #13423 * fix(readme): resolve conflict * chore: align v12 deprecation comments * chore: revert local .all-contributors updates * docs(contextual-layout-tokens): fix comment position * chore: rename storybook layout controls * chore: only show layout controls in dev storybook * fix(button): move icon up 1px * fix(accordion): fix arrow icon position * fix(icon-button): fix icon position * fix(icon-button): fix icon position * fix(overflow-menu): fix icon position * fix(ui-shell): fix header action icon position * fix(code-snippet): fix icon position in button * fix(pagination): fix icon position in button * refactor(contextual-layout-tokens): alternative poc * refactor(contextual-layout-token): implement LayoutConstraint system * refactor(contextual-layout-tokens): re-implement redefine-tokens mixin * docs(contextual-layout-tokens): update docs to reflect refactor * fix(conextual-layout-tokens): remove outdated workarounds * fix(contained-list): make persistent search work with size variants * fix(content-switcher): fix icon-only styles * chore: update datatable snapshot * docs(layout): add information about LayoutConstraint * fix(copy-button): wrap in LayoutConstraint * chore: run prettier * fix: revert unrelated sort change in package.json * chore: update toc of style/docs/sass.md * docs(contextual-layout-tokens): fix css reference * docs(contextual-layout-tokens): fix copy-paste mistake --------- Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package
@carbon/react
Browser
Chrome
Package version
1.25.0
React version
17
Description
IconButton's
sizeprop has an incorrect default ofmd. Buttons have a default size oflg, and this includes the IconButton.ButtonwithhasIconOnlyworks correctly.Some background on this:
size(v11 Beta 3 #10247 (comment))md.Tasks
The text was updated successfully, but these errors were encountered: