Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): update icons for progress indicator #10291

Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix(react): update icons for progress indicator #10291

merged 2 commits into from
Dec 15, 2021

Conversation

abbeyhrt
Copy link
Contributor

Closes #8104

Updates ProgressIndicator icons to match new spec.

Before:

Screen Shot 2021-12-15 at 12 16 19 PM

Now:

Screen Shot 2021-12-15 at 12 19 34 PM

Spec:

Screen Shot 2021-12-15 at 12 21 12 PM

Testing / Reviewing

Go to ProgressIndicator story and verify that it matches the spec provided

@abbeyhrt abbeyhrt requested a review from a team as a code owner December 15, 2021 18:22
@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e2de18f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ba76d7b178c600072e5d37

😎 Browse the preview: https://deploy-preview-10291--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e2de18f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ba76d7d91b1300088139b0

😎 Browse the preview: https://deploy-preview-10291--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: e2de18f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ba76d72d955500074c38e8

😎 Browse the preview: https://deploy-preview-10291--carbon-components-react.netlify.app

@abbeyhrt abbeyhrt requested review from a team and jeanservaas and removed request for a team December 15, 2021 19:03
@abbeyhrt abbeyhrt requested review from thyhmdo, tay1orjones and a team and removed request for jeanservaas December 15, 2021 19:48
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kodiakhq kodiakhq bot merged commit 6235f2a into carbon-design-system:main Dec 15, 2021
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress indicator confused for radio bottons (interactive to progress)
4 participants