-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo: upgrade Carbon to 10.53 #3300
Conversation
Only one test failure related to message change in publicAPI test
Had to add mocks for window.mediaMatches, but otherwise no new test failures
no new test failures
replace with renderSelectedItem in carbon
replace with renderSelectedItem in carbon
replace with renderSelectedItem in carbon
use new renderSelectedItem from carbon instead
✔️ Deploy Preview for ai-apps-pal-angular ready! 🔨 Explore the source changes: 337767b 🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/622bbf69389edd0008e04ad6 😎 Browse the preview: https://deploy-preview-3300--ai-apps-pal-angular.netlify.app |
✔️ Deploy Preview for carbon-addons-iot-react ready! 🔨 Explore the source changes: 337767b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/622bbf69e9f4770008a405fc 😎 Browse the preview: https://deploy-preview-3300--carbon-addons-iot-react.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared all normal stories with next and didn't find any issues
Also tested all experimental stories
Looks like this was intentional. carbon-design-system/carbon#10291 |
@@ -34235,17 +34230,6 @@ Map { | |||
}, | |||
"PasswordInput" => Object { | |||
"$$typeof": Symbol(react.forward_ref), | |||
"defaultProps": Object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to provide any of these deleted default props? the className for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The defaults are still there. Carbon has taken to inlining them instead of using defaultProps
, so they're not showing up in our snapshots, but as for the className in particular. It was actually broken for a very long time. Notice it's actually showing ${prefix}
instead of bx
. The default wasn't using template strings, but a normal string. https://github.com/carbon-design-system/carbon/blame/c2a62f9ce71c9570e9de21d266ccfe81f0ae3e18/packages/react/src/components/TextInput/PasswordInput.js#L339
Closes #
Summary
10.50
10.51
10.52
10.53
Change List (commits, features, bugs, etc)
renderSelectedItem
in new version of CarbonAcceptance Test (how to verify the PR)
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.