Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: upgrade Carbon to 10.53 #3300

Merged
merged 14 commits into from
Mar 14, 2022
Merged

Repo: upgrade Carbon to 10.53 #3300

merged 14 commits into from
Mar 14, 2022

Conversation

kevinsperrine
Copy link
Collaborator

Closes #

Summary

10.50

  • changed publicAPI.test to update warning message from MultiSelect.Filterable

10.51

  • no test failures -- updated snapshots

10.52

  • Had to add mocks for window.mediaMatches, but otherwise no new test failures

10.53

  • No new test failures

Change List (commits, features, bugs, etc)

  • upgraded to carbon 10.53
  • added mock for window.matchMedia
  • updated copy for warning message for deprecated MultiSelect.Filterable
  • replaced temp ref div with forwardedRef in Table/Pagination
  • replaced useDropDownTitleFixer hook with renderSelectedItem in new version of Carbon

Acceptance Test (how to verify the PR)

  • check titles on selected elements in ColorDropdown, IconDropdown, SimpleIconDropdown, TableViewDropdown
  • check table pagination resizes correctly when below 500px (still have open issue to adjust this minimum)

Regression Test (how to make sure this PR doesn't break old functionality)

  • standard carbon upgrade work to check stories

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for ai-apps-pal-angular ready!

🔨 Explore the source changes: 337767b

🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/622bbf69389edd0008e04ad6

😎 Browse the preview: https://deploy-preview-3300--ai-apps-pal-angular.netlify.app

@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for carbon-addons-iot-react ready!

🔨 Explore the source changes: 337767b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/622bbf69e9f4770008a405fc

😎 Browse the preview: https://deploy-preview-3300--carbon-addons-iot-react.netlify.app/

@bjornalm
Copy link
Contributor

Only real difference I found comparing with next is this. Can't tell if it is an issue or a design update.
image
image

Copy link
Contributor

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared all normal stories with next and didn't find any issues
Also tested all experimental stories

@kevinsperrine
Copy link
Collaborator Author

Only real difference I found comparing with next is this. Can't tell if it is an issue or a design update. image image

Looks like this was intentional. carbon-design-system/carbon#10291

@@ -34235,17 +34230,6 @@ Map {
},
"PasswordInput" => Object {
"$$typeof": Symbol(react.forward_ref),
"defaultProps": Object {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to provide any of these deleted default props? the className for instance.

Copy link
Collaborator Author

@kevinsperrine kevinsperrine Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults are still there. Carbon has taken to inlining them instead of using defaultProps, so they're not showing up in our snapshots, but as for the className in particular. It was actually broken for a very long time. Notice it's actually showing ${prefix} instead of bx. The default wasn't using template strings, but a normal string. https://github.com/carbon-design-system/carbon/blame/c2a62f9ce71c9570e9de21d266ccfe81f0ae3e18/packages/react/src/components/TextInput/PasswordInput.js#L339

@kodiakhq kodiakhq bot merged commit cb97dc1 into next Mar 14, 2022
@kodiakhq kodiakhq bot deleted the carbon-upgrade-10.53 branch March 14, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants