-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CWC Tearsheet #11545
Merged
ariellalgilmore
merged 16 commits into
carbon-design-system:main
from
lee-chase:cwc-tearsheet
Feb 27, 2024
Merged
feat: Add CWC Tearsheet #11545
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
da7b3cc
chore: tearsheet wip
lee-chase 195448a
feat: add navigation
lee-chase d96b960
feat: add influencer
lee-chase bd1efa1
Merge branch 'main' into cwc-tearsheet
lee-chase bd43d0d
Merge branch 'main' into cwc-tearsheet
lee-chase 3202a62
feat: update to ai v2 styling
lee-chase 41344d3
fix: header actions location
lee-chase 9432954
Merge branch 'main' into cwc-tearsheet
lee-chase 9926d06
Merge branch 'main' into cwc-tearsheet
lee-chase da069c4
Merge branch 'main' into cwc-tearsheet
lee-chase 19591ff
Update packages/carbon-web-components/src/components/side-panel/side-…
lee-chase ad6098c
Update packages/carbon-web-components/src/components/tearsheet/tearsh…
lee-chase 9635516
fix: review updates
lee-chase dda5a89
fix: cds usage in tearsheet styles
lee-chase 03e65eb
Merge branch 'main' into cwc-tearsheet
ariellalgilmore e298a79
chore(merge): resolve conflicts
ariellalgilmore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file removed
BIN
-1.25 MB
.yarn/cache/@carbon-ibm-products-styles-npm-2.25.0-8cace83d86-e7f0895ea9.zip
Binary file not shown.
Binary file added
BIN
+1.28 MB
.yarn/cache/@carbon-ibm-products-styles-npm-2.27.1-936e33a14a-42ef53c93c.zip
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
packages/carbon-web-components/src/components/button/button-set-base.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* @license | ||
* | ||
* Copyright IBM Corp. 2020, 2024 | ||
* | ||
* This source code is licensed under the Apache-2.0 license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
import { LitElement, html } from 'lit'; | ||
import { customElement } from 'lit/decorators.js'; | ||
import styles from './button.scss'; | ||
import { prefix } from '../../globals/settings'; | ||
|
||
/** | ||
* Button set without button checks | ||
* | ||
* @element cds-button-set-base | ||
*/ | ||
@customElement(`${prefix}-button-set-base`) | ||
class CDSButtonSetBase extends LitElement { | ||
render() { | ||
return html`<slot></slot>`; | ||
} | ||
|
||
connectedCallback() { | ||
super.connectedCallback(); | ||
this.setAttribute('role', 'list'); | ||
} | ||
|
||
static styles = styles; // `styles` here is a `CSSResult` generated by custom WebPack loader | ||
} | ||
/* @__GENERATE_REACT_CUSTOM_ELEMENT_TYPE__ */ | ||
export default CDSButtonSetBase; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 0 additions & 28 deletions
28
packages/carbon-web-components/src/components/side-panel/side-panel-button-set.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
packages/carbon-web-components/src/components/tearsheet/defs.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* @license | ||
* | ||
* Copyright IBM Corp. 2023, 2024 | ||
* | ||
* This source code is licensed under the Apache-2.0 license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
export enum TEARSHEET_INFLUENCER_PLACEMENT { | ||
/** right / default */ | ||
RIGHT = 'right', | ||
|
||
/** left */ | ||
LEFT = 'left', | ||
} | ||
|
||
export enum TEARSHEET_INFLUENCER_WIDTH { | ||
/** narrow /default */ | ||
NARROW = 'narrow', | ||
/** wide */ | ||
WIDE = 'wide', | ||
} | ||
|
||
export enum TEARSHEET_WIDTH { | ||
/** narrow */ | ||
NARROW = 'narrow', | ||
/** wide */ | ||
WIDE = 'wide', | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to delete this and create the
button-set-base
? I think it would be better not to touch the core components at this point unless we need toThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tearsheet also uses the button set without kinds being updated and it did not make sense to call it side-panel-button-set.