Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CWC Tearsheet #11545

Merged
merged 16 commits into from
Feb 27, 2024
Merged

feat: Add CWC Tearsheet #11545

merged 16 commits into from
Feb 27, 2024

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

Closes #carbon-design-system/carbon-labs#17

Description

First pass at creating Tearsheet as a web component.

Changelog

New

  • Experimental tearsheet

Changed

  • Create ButtonSetBase so as to share between side panel and tearsheet

Removed

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11545/index.html

Built with commit: e298a7945b79dd59fbf6a21847ef740c44334a0f

@lee-chase lee-chase marked this pull request as ready for review February 19, 2024 15:59
@lee-chase lee-chase requested a review from a team as a code owner February 19, 2024 15:59
@lee-chase lee-chase requested review from IgnacioBecerra and annawen1 and removed request for a team February 19, 2024 15:59
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 21, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11545/index.html

Built with commit: e298a7945b79dd59fbf6a21847ef740c44334a0f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 21, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11545/index.html

Built with commit: e298a7945b79dd59fbf6a21847ef740c44334a0f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 21, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11545/index.html

Built with commit: e298a7945b79dd59fbf6a21847ef740c44334a0f

@lee-chase lee-chase marked this pull request as draft February 21, 2024 16:12
@lee-chase lee-chase marked this pull request as ready for review February 21, 2024 17:41
ariellalgilmore
ariellalgilmore reviewed Feb 23, 2024
View reviewed changes
packages/carbon-web-components/src/components/side-panel/side-panel-button-set.ts Outdated
Copy link
Member

@ariellalgilmore ariellalgilmore Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to delete this and create the button-set-base? I think it would be better not to touch the core components at this point unless we need to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tearsheet also uses the button set without kinds being updated and it did not make sense to call it side-panel-button-set.

packages/carbon-web-components/src/components/side-panel/side-panel.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/tearsheet/tearsheet.scss Outdated Show resolved Hide resolved
@lee-chase lee-chase mentioned this pull request Feb 27, 2024
Merged
@lee-chase
Copy link
Member Author

Added #11586 PR which builds on this. Happy to merge into this PR if desirable.

ariellalgilmore
ariellalgilmore approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Feb 27, 2024
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Feb 27, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 27, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@ariellalgilmore ariellalgilmore merged commit fd18753 into carbon-design-system:main Feb 27, 2024
12 of 19 checks passed
@annawen1
Copy link
Member

Hey there! This issue/pull request was referenced in recently released v2.5.0.

@kennylam kennylam mentioned this pull request Mar 13, 2024
Open
@IgnacioBecerra IgnacioBecerra self-assigned this Mar 13, 2024
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@lee-chase @ariellalgilmore
feat: Add CWC Tearsheet (carbon-design-system#11545)
e4ed585 
* chore: tearsheet wip

* feat: add navigation

* feat: add influencer

* feat: update to ai v2 styling

* fix: header actions location

* Merge branch 'main' into cwc-tearsheet

* Update packages/carbon-web-components/src/components/side-panel/side-panel.ts

Co-authored-by: Ariella Gilmore <[email protected]>

* Update packages/carbon-web-components/src/components/tearsheet/tearsheet.scss

Co-authored-by: Ariella Gilmore <[email protected]>

* fix: review updates

* fix: cds usage in tearsheet styles

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@IgnacioBecerra IgnacioBecerra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lee-chase @ibmdotcom-bot @annawen1 @ariellalgilmore @IgnacioBecerra