Tooltips fix #98
Merged
Tooltips fix #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove eventlistener from base-axis-chart reimplement in bar-chart Enchancement carbon-design-system#97: Remove addDataPointEventListener() from base-axis-chart.ts
darsi-an
requested review from
cal-smith,
theiliad and
zvonimirfras
as code owners
|
Deploy preview for kind-hypatia-c6b5c4 ready! Built with commit 3829954 |
theiliad
requested changes
Nov 19, 2018
packages/core/src/base-axis-chart.ts
Outdated
|
|
||
| self.hideTooltip(); | ||
| }); | ||
| return; |
There was a problem hiding this comment.
This function should throw an error saying:
console.warn("You should implement your own `addDataPointEventListener()` function.");No return needed btw.
| @@ -1,8 +1,5 @@ | |||
| // D3 Imports | |||
| import { | |||
| mouse, | |||
carbon-design-system#97 Remove addDataPointEventListener() from base-axis-chart.ts
theiliad
approved these changes
Nov 20, 2018
zvonimirfras
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97
Updates
Demo screenshot or recording
Review checklist (for reviewers only)