Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove addDataPointEventListener() from base-axis-chart.ts #97

Closed
theiliad opened this issue Nov 17, 2018 · 0 comments
Closed

Remove addDataPointEventListener() from base-axis-chart.ts #97

theiliad opened this issue Nov 17, 2018 · 0 comments
Assignees
@theiliad @darsi-an
Labels
type: enhancement 💡

Comments

@theiliad
Copy link
Member

theiliad commented Nov 17, 2018 •
edited
Loading

This function runs different logic for bar & line charts, therefore should be removed.

https://github.com/IBM/carbon-charts/blob/936e600a98129aab55494fa6e253df480057dc3a/packages/core/src/base-axis-chart.ts#L598-L648
darsi-an added a commit to darsi-an/carbon-charts that referenced this issue Nov 18, 2018
@darsi-an
fix(core): Remove and update addDataPointEventListener
f40f775 
Remove eventlistener from base-axis-chart reimplement in bar-chart

Enchancement carbon-design-system#97: Remove addDataPointEventListener() from base-axis-chart.ts
darsi-an added a commit to darsi-an/carbon-charts that referenced this issue Nov 20, 2018
@darsi-an
style(core): console log message for base-axis-chart event listener
3829954 
carbon-design-system#97 Remove addDataPointEventListener() from base-axis-chart.ts
@darsi-an darsi-an mentioned this issue Nov 20, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theiliad theiliad

@darsi-an darsi-an

Labels
type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theiliad @darsi-an