minor ci update around coverage/bench compare (we've seen issues in prs) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/minor-ci-update
branch
2 times, most recently
from
87afa26 to
4e23677
Compare
zeeshanlakhani
changed the title
- remove need for codecov token in codecov action * action doesn't need it in public repos and will cause issues w/ forks where secrets don't persist - comment out coverage job until xd009642/tarpaulin#461 is solved. - allow critcmp comparisons to fail until BurntSushi/critcmp#5 is handled
zeeshanlakhani
force-pushed
the
zl/minor-ci-update
branch
from
4e23677 to
958ccc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
critcmpcomparison on bench-pr due to issue ~ Internal file format changes BurntSushi/critcmp#5.