-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal file format changes #5
Comments
zeeshanlakhani
pushed a commit
to capsule-rs/capsule
that referenced
this issue
Jul 3, 2020
- remove need for codecov token in codecov action * action doesn't need it in public repos and will cause issues w/ forks where secrets don't persist - comment out coverage job until xd009642/tarpaulin#461 is solved. - bench-pr will fail on comparison due to criterion change upstream in format * related to BurntSushi/critcmp#5. Future comparisons should work fine.
@bheisler would this be related to this new error I'm seeing when running
Thanks. |
Probably related, yes. |
zeeshanlakhani
pushed a commit
to capsule-rs/capsule
that referenced
this issue
Jul 6, 2020
- remove need for codecov token in codecov action * action doesn't need it in public repos and will cause issues w/ forks where secrets don't persist - comment out coverage job until xd009642/tarpaulin#461 is solved. - allow critcmp comparisons to fail until BurntSushi/critcmp#5 is handled
zeeshanlakhani
added a commit
to capsule-rs/capsule
that referenced
this issue
Jul 6, 2020
- remove need for codecov token in codecov action * action doesn't need it in public repos and will cause issues w/ forks where secrets don't persist - comment out coverage job until xd009642/tarpaulin#461 is solved. - allow critcmp comparisons to fail until BurntSushi/critcmp#5 is handled
yamafaktory
added a commit
to yamafaktory/jql
that referenced
this issue
Aug 6, 2020
yamafaktory
added a commit
to yamafaktory/jql
that referenced
this issue
Aug 6, 2020
* chore: use license instead of license-file Bump up deps too. * fix: downgrade criterion version BurntSushi/critcmp#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, this is just a heads-up that the internal file formats used by Criterion.rs will be changing in the next release. Specifically,
sample.json
andestimates.json
. Since they are internal files I don't consider this a breaking change, but I thought I'd let you know so you can update critcmp.New
sample.json
format contains oneSavedSample
:New
estimates.json
format contains oneEstimates
:I should also mention that cargo-criterion has its own completely separate file structure using CBOR instead of JSON. It's getting pretty late here so I'll let you get the structure for that from the code.
The text was updated successfully, but these errors were encountered: