Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements customElements.getName() and fixes letter case handling. #1177

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

mash-graz
Copy link
Contributor

Adding the getName() method was a rather trivial task, but it doesn't make much sense without trying to fix the much more complicated letter case resp. case-sensitivity issues regarding the custom element registry, because otherwise we would return an invalid identifier.

The custom element specification requires names, that do not contain capital ASCII letters and case-sensitive letters of some Unicode ranges. It's closer the XML conventions than traditional HTML. To emphasize this difference I also used the variable name localName instead of tagName in the relevant code sections, because element.tagName will always use capital letters, while the corresponding localName mostly uses lowercase.

Fixes: #1176

@capricorn86
Copy link
Owner

I'm looking into this. Still some more things I want to check.

@mash-graz
Copy link
Contributor Author

mash-graz commented Feb 1, 2024

I'm looking into this. Still some more things I want to check.

There is no hurry. :)

Unfortunately I'm also rather busy with other jobs. Therefor I also couldn't review your extensive node-dependency-reduction-solution util now, but I will take a look as soon as possible.

@capricorn86 capricorn86 merged commit b306b1a into capricorn86:master Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customElements.getName() missing and invalid custom element name case handling.
2 participants