Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customElements.getName() missing and invalid custom element name case handling. #1176

Closed
mash-graz opened this issue Dec 8, 2023 · 0 comments · Fixed by #1177
Closed

customElements.getName() missing and invalid custom element name case handling. #1176

mash-graz opened this issue Dec 8, 2023 · 0 comments · Fixed by #1177
Labels
bug Something isn't working

Comments

@mash-graz
Copy link
Contributor

Describe the bug

  1. The method customElements.getName() isn't implemented until now.

  2. And while trying to fix this issues I had to figure out, that happy-dom makes some fundamental wrong assumptions about custom element naming. It internally translates all tag names to uppercase for case-insensitive lookups, but the specification to the contrary does only allow lowercase ASCII letters in valid custom element names anyway (https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name).

I'll try to send you a PR to fix these issues soon.
@mash-graz mash-graz added the bug Something isn't working label Dec 8, 2023
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 10, 2023
@mash-graz
capricorn86#1176@patch: Implement customElements.getName().
806e960
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 10, 2023
@mash-graz
capricorn86#1176@patch: Implement custom element name validation.
fb72997
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 10, 2023
@mash-graz
capricorn86#1176@patch: Custom Elements letter case handling.
8f3bbe1
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 10, 2023
@mash-graz
capricorn86#1176@patch: Prevent custom element redefinition.
0e14dbb
@mash-graz mash-graz mentioned this issue Dec 10, 2023
Merged
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 10, 2023
@mash-graz
capricorn86#1176@patch: Prevent custom element redefinition.
1997a86
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 11, 2023
@mash-graz
capricorn86#1176@patch: Prevent custom element registration under a d…
57ad4d7 
…ifferent name.
mash-graz added a commit to mash-graz/happy-dom that referenced this issue Dec 11, 2023
@mash-graz
capricorn86#1176@patch: Prevent custom element registration under a d…
36b2c8e 
…ifferent name.
capricorn86 added a commit to mash-graz/happy-dom that referenced this issue Feb 20, 2024
@capricorn86
fix: [capricorn86#1176] Use localName correctly in Document.createEle…
cee03ab 
…ment() and Document.createElementNS()
capricorn86 added a commit to mash-graz/happy-dom that referenced this issue Feb 21, 2024
@capricorn86
feat: [capricorn86#1176] Adds support for Window.happyDOM.close().
bbdbf88
capricorn86 added a commit to mash-graz/happy-dom that referenced this issue Feb 21, 2024
@capricorn86
feat: [capricorn86#1176] Adds support for Window.happyDOM.close().
2e6980a
capricorn86 added a commit to mash-graz/happy-dom that referenced this issue Feb 21, 2024
@capricorn86
feat: [capricorn86#1176] Adds support for Window.happyDOM.close().
2279309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements customElements.getName() and fixes letter case handling. mash-graz/happy-dom
1 participant
@mash-graz