Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating Action Policy, replace gotest.tools with testify and unify cmds naming #457

Merged
merged 7 commits into from
Aug 23, 2021
Merged

Fix creating Action Policy, replace gotest.tools with testify and unify cmds naming #457

merged 7 commits into from
Aug 23, 2021

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Aug 20, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix creating Action Policy
  • Replace gotest.tools with testify
  • Unify cmds naming

@mszostok mszostok added bug Something isn't working area/engine Relates to Engine labels Aug 20, 2021
@mszostok mszostok added this to the 0.5.0 milestone Aug 20, 2021
@mszostok mszostok added the WIP Work in progress label Aug 20, 2021
@mszostok mszostok changed the title Fix creating Action Policy Fix creating Action Policy, replace gotest.tools with testify and unify cmds naming Aug 23, 2021
This was referenced Aug 23, 2021
Closed
Merged
pkosiec
pkosiec approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/k8s-engine/graphql/domain/action/fixtures_test.go Outdated Show resolved Hide resolved
@pkosiec pkosiec self-assigned this Aug 23, 2021
@mszostok mszostok added enhancement New feature or request and removed WIP Work in progress labels Aug 23, 2021
@mszostok mszostok merged commit ab4db00 into capactio:main Aug 23, 2021
@mszostok mszostok deleted the policy/action-policy branch August 23, 2021 10:49
@mszostok mszostok mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@lukaszo lukaszo Awaiting requested review from lukaszo

@platten platten Awaiting requested review from platten

@Trojan295 Trojan295 Awaiting requested review from Trojan295

Assignees

@pkosiec pkosiec

Labels
area/engine Relates to Engine bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec